From: Jan Beulich <jbeulich@suse.com>
To: dmkhn@proton.me
Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com,
roger.pau@citrix.com, dmukhin@ford.com
Subject: Re: [PATCH v2] x86/vmx: Update __vmread() signature
Date: Wed, 23 Apr 2025 08:56:50 +0200 [thread overview]
Message-ID: <9fca39ed-e3f2-45db-8041-1157eaecd25d@suse.com> (raw)
In-Reply-To: <aAgUKi8DadC6ZPMI@starscream>
On 23.04.2025 00:11, dmkhn@proton.me wrote:
> On Tue, Apr 22, 2025 at 09:56:00AM +0200, Jan Beulich wrote:
>> On 22.04.2025 03:15, dmkhn@proton.me wrote:
>>> From: Denis Mukhin <dmukhin@ford.com>
>>>
>>> Current implementation of __vmread() returns the result via pointer argument
>>> which leads to having excess code in some places.
>>>
>>> Update the signature of __vmread() to return `unsigned long` and drop the
>>> pointer argument as per suggestion in [1].
>>>
>>> Update all call sites everywhere in the VT-x code.
>>
>> You did read Andrew's reply to v1 before posting v2, didn't you?
>
> I missed to address the function name change request, posted v3:
> https://lore.kernel.org/xen-devel/20250422215833.522007-1-dmukhin@ford.com/
That was only part of what was asked for. Andrew also gave a pretty clear outline
of how to avoid the need to touch all use sites in one single patch. Plus he
explained why it's better to do this in smaller steps.
Jan
prev parent reply other threads:[~2025-04-23 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 1:15 [PATCH v2] x86/vmx: Update __vmread() signature dmkhn
2025-04-22 7:56 ` Jan Beulich
2025-04-22 22:11 ` dmkhn
2025-04-23 6:56 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fca39ed-e3f2-45db-8041-1157eaecd25d@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dmkhn@proton.me \
--cc=dmukhin@ford.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.