From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
Frediano Ziglio <frediano.ziglio@cloud.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 1/5] x86/boot: create a C bundle for 32 bit boot code and use it
Date: Fri, 11 Oct 2024 14:21:26 +0100 [thread overview]
Message-ID: <9fd32ff0-9be4-42a5-b1fa-e663d710b9d2@citrix.com> (raw)
In-Reply-To: <1f9ea2e9-d2ce-4ae1-9a93-dffc856c1268@suse.com>
On 11/10/2024 2:20 pm, Jan Beulich wrote:
> On 11.10.2024 10:52, Frediano Ziglio wrote:
>> diff --git a/xen/tools/combine_two_binaries b/xen/tools/combine_two_binaries
>> new file mode 100755
>> index 0000000000..ea2d6ddc4e
>> --- /dev/null
>> +++ b/xen/tools/combine_two_binaries
>> @@ -0,0 +1,198 @@
>> +#!/usr/bin/env python3
> Nit: Such files, by convention, are named *.py, I think.
Yes please, and I forgot it on my python review.
~Andrew
next prev parent reply other threads:[~2024-10-11 13:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 8:52 [PATCH v3 0/5] Reuse 32 bit C code more safely Frediano Ziglio
2024-10-11 8:52 ` [PATCH v3 1/5] x86/boot: create a C bundle for 32 bit boot code and use it Frediano Ziglio
2024-10-11 10:57 ` [Makefile only] " Andrew Cooper
2024-10-11 13:17 ` [python] " Andrew Cooper
2024-10-11 13:53 ` Frediano Ziglio
2024-10-11 13:20 ` Jan Beulich
2024-10-11 13:21 ` Andrew Cooper [this message]
2024-10-11 8:52 ` [PATCH v3 2/5] x86/boot: Reuse code to relocate trampoline Frediano Ziglio
2024-10-11 12:02 ` Andrew Cooper
2024-10-11 12:50 ` Jan Beulich
2024-10-11 8:52 ` [PATCH v3 3/5] x86/boot: Use boot_vid_info variable directly from C code Frediano Ziglio
2024-10-11 12:07 ` Andrew Cooper
2024-10-11 8:52 ` [PATCH v3 4/5] x86/boot: Use trampoline_phys " Frediano Ziglio
2024-10-11 12:05 ` Andrew Cooper
2024-10-11 8:52 ` [PATCH v3 5/5] x86/boot: Clarify comment Frediano Ziglio
2024-10-11 12:56 ` Alejandro Vallejo
2024-10-11 13:08 ` Frediano Ziglio
2024-10-11 13:28 ` Alejandro Vallejo
2024-10-11 13:38 ` Andrew Cooper
2024-10-11 13:58 ` Frediano Ziglio
2024-10-11 15:06 ` Alejandro Vallejo
2024-10-11 16:07 ` Andrew Cooper
2024-10-11 14:06 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fd32ff0-9be4-42a5-b1fa-e663d710b9d2@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=frediano.ziglio@cloud.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.