From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A030C46CD2 for ; Sun, 28 Jan 2024 03:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=erWSQ7kRUh8RtDN6LgFgmb/crnBARnqjILlO+zZPgew=; b=WgOurw/+TkERf+z1BTnvYk85YO FwACC/xFqe7XTf+BeOnMM85KTza1U5JXCGG87Cwe7GZga2x7LAiwU/Q7z5pr5JBu7KS8FaNLt5EpO olJNzbwV574DqC+SIN7XOhwV6LeHD/FdTb7i8ZRRcn634v7FZtFY38oQIgmYr2Miv651oWwY1O2dr tZyHONVEI8tDI/gwz+c0BLSQwbF1DXl9AlBpM7EeXeXzebTBOr2Er/4iRvcgfPCaZju3Opa7QsUxE ShiK9tAqk1WenYbySUBK1C5fqWdnl8aZ98OVMWaDM4hF300XnWF1CTB6vkyOf3plYdAM33n6eKqFe H86deYvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTvxt-00000008epx-0uyJ; Sun, 28 Jan 2024 03:36:13 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTvxn-00000008eoe-0EcQ; Sun, 28 Jan 2024 03:36:10 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1706412958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGynTAOYEGgnqBwfLRvahiiezGVmO/RYQ5/JRIx6Ctk=; b=KG6rScrRZHwd6CM0HJJfXU/XWE00HNFc5rAeAejlPdmECoKkqpbO62Qeqy2q9DNE9cgk9g P9io/r1zWzHMvU6jV6jd32bXQecZALlr61VkUpTB/5GQ2ye5R8Q4fOdg29UXOc/LtNLcup DasNWw3fAqWceknmDXZHUp/OaSdniHAmUluORsO6YZvv/5FksGr6k5JTBgfYjUyZJckAH8 VNa17VsMXlMhKqg4XfYGkhP+H+5Q595YPnsmv+odGHio5qtz8SlX/gJ56i2zKTF7lT8HiM 77ORaZwK7M77FpFPPJzoOA6X4MAquOIRGWP67I5YXk20m+vMBt7JIA0TsIUBPQ== Date: Sun, 28 Jan 2024 04:35:58 +0100 From: Dragan Simic To: Alexey Charkov Cc: Daniel Lezcano , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Viresh Kumar Subject: Re: [PATCH 4/4] arm64: dts: rockchip: Add OPP data for CPU cores on RK3588 In-Reply-To: References: <20240125-rk-dts-additions-v1-0-5879275db36f@gmail.com> <20240125-rk-dts-additions-v1-4-5879275db36f@gmail.com> <731aac66-f698-4a1e-b9ee-46a7f24ecae5@linaro.org> <1f0608831cfb95c80edf16cd751eee76@manjaro.org> <528a37d84cdd871e717b4ebf648bb8a7@manjaro.org> <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> <5ef9bab979260884866efe30d19ba8f1@manjaro.org> Message-ID: <9fda41efe365241ce06bd58974c8e055@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_193607_773230_70F5CBFC X-CRM114-Status: GOOD ( 42.67 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMS0yNyAyMDo0MSwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gU2F0LCBKYW4g MjcsIDIwMjQgYXQgMTI6MzPigK9BTSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJvLm9yZz4g Cj4gd3JvdGU6Cj4+IE9uIDIwMjQtMDEtMjYgMTQ6NDQsIEFsZXhleSBDaGFya292IHdyb3RlOgo+ PiA+IE9uIEZyaSwgSmFuIDI2LCAyMDI0IGF0IDQ6NTbigK9QTSBEYW5pZWwgTGV6Y2FubyA8ZGFu aWVsLmxlemNhbm9AbGluYXJvLm9yZz4gd3JvdGU6Cj4+ID4+IE9uIDI2LzAxLzIwMjQgMDg6NDks IERyYWdhbiBTaW1pYyB3cm90ZToKPj4gPj4gPiBPbiAyMDI0LTAxLTI2IDA4OjMwLCBBbGV4ZXkg Q2hhcmtvdiB3cm90ZToKPj4gPj4gPj4gT24gRnJpLCBKYW4gMjYsIDIwMjQgYXQgMTE6MDXigK9B TSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJvLm9yZz4gd3JvdGU6Cj4+ID4+ID4+PiBPbiAy MDI0LTAxLTI2IDA3OjQ0LCBBbGV4ZXkgQ2hhcmtvdiB3cm90ZToKPj4gPj4gPj4+ID4gT24gRnJp LCBKYW4gMjYsIDIwMjQgYXQgMTA6MzLigK9BTSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJv Lm9yZz4gd3JvdGU6Cj4+ID4+ID4+PiA+PiBPbiAyMDI0LTAxLTI1IDEwOjMwLCBEYW5pZWwgTGV6 Y2FubyB3cm90ZToKPj4gPj4gPj4gVGhyb3R0bGluZyB3b3VsZCBhbHNvIGxvd2VyIHRoZSB2b2x0 YWdlIGF0IHNvbWUgcG9pbnQsIHdoaWNoIGNvb2xzIGl0Cj4+ID4+ID4+IGRvd24gbXVjaCBmYXN0 ZXIhCj4+ID4+ID4KPj4gPj4gPiBPZiBjb3Vyc2UsIGJ1dCB0aGUga2V5IGlzIG5vdCB0byBjb29s IChhbmQgc2xvdyBkb3duKSB0aGUgQ1BVIGNvcmVzIHRvbwo+PiA+PiA+IG11Y2gsIGJ1dCBqdXN0 IGVub3VnaCB0byBzdGF5IHdpdGhpbiB0aGUgYXZhaWxhYmxlIHRoZXJtYWwgZW52ZWxvcGUsCj4+ ID4+ID4gd2hpY2ggaXMgd2hlcmUgdGhlIHNhbWUtdm9sdGFnZSwgbG93ZXItZnJlcXVlbmN5IE9Q UHMgc2hvdWxkIHNoaW5lLgo+PiA+Pgo+PiA+PiBUaGF0IGltcGxpZXMgdGhlIHJlc3VsdGluZyBw b3dlciBpcyBzdXN0YWluYWJsZSB3aGljaCBJIGRvdWJ0IGl0IGlzCj4+ID4+IHRoZQo+PiA+PiBj YXNlLgo+PiA+Pgo+PiA+PiBUaGUgdm9sdGFnZSBzY2FsaW5nIG1ha2VzIHRoZSBjb29saW5nIGVm ZmVjdCBlZmZpY2llbnQgbm90IHRoZQo+PiA+PiBmcmVxdWVuY3kuCj4+ID4+Cj4+ID4+IEZvciBl eGFtcGxlOgo+PiA+PiAgICAgICAgIG9wcDUgPSBvcHAoMkdIeiwgMVYpID0+IDIgQm9nb1dhdHQK Pj4gPj4gICAgICAgICBvcHA0ID0gb3BwKDEuOUdIeiwgMVYpID0+IDEuOSBCb2dvV2F0dAo+PiA+ PiAgICAgICAgIG9wcDMgPSBvcHAoMS44R0h6LCAwLjlWKSA9PiAxLjQ1OCBCb2dvV2F0dAo+PiA+ PiAgICAgICAgIFsgb3RoZXIgc3RhdGVzIGJ1dCB3ZSBmb2N1cyBvbiB0aGVzZSAzIF0KPj4gPj4K Pj4gPj4gb3BwNS0+b3BwNCA9PiAtNSUgY29tcHV0ZSBjYXBhY2l0eSwgLTUlIHBvd2VyLCByYXRp bz0xCj4+ID4+IG9wcDQtPm9wcDMgPT4gLTUlIGNvbXB1dGUgY2FwYWNpdHksIC0yMy4xJSBwb3dl ciwgcmF0aW89MjEsNgo+PiA+Pgo+PiA+PiBvcHA1LT5vcHAzID0+IC0xMCUgY29tcHV0ZSBjYXBh Y2l0eSwgLTI3LjElIHBvd2VyLCByYXRpbz0zNi45Cj4+ID4+Cj4+ID4+IEluIGJ1cnN0IG9wZXJh dGlvbiAobm8gdGhlcm1hbCB0aHJvdHRsaW5nKSwgb3BwNCBpcyBwb2ludGxlc3Mgd2UgYWdyZWUK Pj4gPj4gb24gdGhhdC4KPj4gPj4KPj4gPj4gSU1PIHRoZSBmb2xsb3dpbmcgd2lsbCBoYXBwZW46 IGluIGJ1cnN0IG9wZXJhdGlvbiB3aXRoIHRoZXJtYWwKPj4gPj4gdGhyb3R0bGluZyB3ZSBoaXQg dGhlIHRyaXAgcG9pbnQgYW5kIHRoZW4gdGhlIHN0ZXAgd2lzZSBnb3Zlcm5vcgo+PiA+PiByZWR1 Y2VzCj4+ID4+IG9wcDUgLT4gb3BwNC4gV2UgaGF2ZSBzbGlnaHQgcG93ZXIgcmVkdWN0aW9uIGJ1 dCB0aGUgdGVtcGVyYXR1cmUgZG9lcwo+PiA+PiBub3QgZGVjcmVhc2UsIHNvIGF0IHRoZSBuZXh0 IGl0ZXJhdGlvbiwgaXQgaXMgdGhyb3R0bGUgYXQgb3BwMy4gQW5kIGF0Cj4+ID4+IHRoZSBlbmQg d2UgaGF2ZSBvcHA0IDwtPiBvcHAzIGJhY2sgYW5kIGZvcnRoIGluc3RlYWQgb2Ygb3BwNSA8LT4g b3BwMy4KPj4gPj4KPj4gPj4gSXQgaXMgcHJvYmFibGUgd2UgZW5kIHVwIHdpdGggYW4gZXF1aXZh bGVudCBmcmVxdWVuY3kgYXZlcmFnZSAob3IKPj4gPj4gY29tcHV0ZSBjYXBhY2l0eSBhdmcpLgo+ PiA+Pgo+PiA+PiBvcHA0IDwtPiBvcHAzIChsb25nZXIgZHVyYXRpb24gaW4gc3RhdGVzLCBsZXNz IHRyYW5zaXRpb25zKQo+PiA+PiBvcHA1IDwtPiBvcHAzIChzaG9ydGVyIGR1cmF0aW9uIGluIHN0 YXRlcywgbW9yZSB0cmFuc2l0aW9ucykKPj4gPj4KPj4gPj4gU29tZSBwbGF0Zm9ybXMgaGFkIHRo ZWlyIGhpZ2hlciBPUFBzIHdpdGggdGhlIHNhbWUgdm9sdGFnZSBhbmQgdGhleQo+PiA+PiBmYWls ZWQgdG8gY29vbCBkb3duIHRoZSBDUFUgaW4gdGhlIGxvbmcgcnVuLgo+PiA+Pgo+PiA+PiBBbnl3 YXksIHRoZXJlIGlzIG9ubHkgb25lIHdheSB0byBjaGVjayBpdCBvdXQgOikKPj4gPj4KPj4gPj4g QWxleGV5LCBpcyBpdCBwb3NzaWJsZSB0byBjb21wYXJlIHRoZSBjb21wdXRlIGR1cmF0aW9uIGZv ciAnZGhyeXN0b25lJwo+PiA+PiB3aXRoIHRoZXNlIHZvbHRhZ2UgT1BQIGFuZCB3aXRob3V0ID8g KHdpdGggYSBwZXJpb2Qgb2YgY29vbCBkb3duCj4+ID4+IGJldHdlZW4KPj4gPj4gdGhlIHRlc3Qg aW4gb3JkZXIgdG8gc3RhcnQgYXQgdGhlIHNhbWUgdGhlcm1hbCBjb25kaXRpb24pID8KPj4gPgo+ PiA+IFN1cmUsIGxldCBtZSB0cnkgdGhhdCAtIHdvdWxkIGJlIGludGVyZXN0aW5nIHRvIHNlZSB0 aGUgcmVzdWx0cy4gSW4gbXkKPj4gPiBwcmV2aW91cyB0aW5rZXJpbmcgdGhlcmUgd2VyZSBjYXNl cyB3aGVuIHRoZSBzeXN0ZW0gc3RheWVkIGF0IDIuMzVHSHoKPj4gPiBmb3IgYWxsIGJpZyBjb3Jl cyBmb3Igbm9uLXRyaXZpYWwgdGltZSAodXNpbmcgdGhlIHN0ZXAtd2lzZSB0aGVybWFsCj4+ID4g Z292ZXJub3IpLCBhbmQgdGhhdCdzIGFuIGV4YW1wbGUgb2YgInNhbWUgdm9sdGFnZSwgbG93ZXIg ZnJlcXVlbmN5Ii4KPj4gPiBPdGhlciB0aW1lcyB0aG91Z2ggaXQgdGhyb3R0bGVkIG9uZSBjbHVz dGVyIGRvd24gdG8gMS44R0h6IGFuZCBrZXB0Cj4+ID4gdGhlIG90aGVyIGF0IDIuNEdIeiwgYW5k IHdhcyBhbHNvIHN0YXRpb25hcnkgYXQgdGhvc2UgcGFyYW1ldGVycyBmb3IKPj4gPiBleHRlbmRl ZCB0aW1lLiBUaGlzIHByb2JhYmx5IGluZGljYXRlcyB0aGF0IGJvdGggb2YgdGhvc2Ugc3RhdGVz IHVzZQo+PiA+IHN1c3RhaW5hYmxlIHBvd2VyIGluIG15IGNvb2xpbmcgc2V0dXAuCj4+IAo+PiBJ TUhPLCB0aGVyZSBhcmUgc2ltcGx5IHRvbyBtYW55IGZhY3RvcnMgYXQgcGxheSwgaW5jbHVkaW5n IGRpZmZlcmVudAo+PiBwb3NzaWJsZSBjb29saW5nIHNldHVwcywgc28gcHJvdmlkaW5nIGFkZGl0 aW9uYWwgQ1BVIHRocm90dGxpbmcKPj4gZ3JhbnVsYXJpdHkgY2FuIG9ubHkgYmUgaGVscGZ1bC4g IE9mIGNvdXJzZSwgdGVzdGluZyBhbmQgcmVjb3JkaW5nCj4+IGRhdGEgaXMgdGhlIHdheSB0byBt b3ZlIGZvcndhcmQsIGJ1dCBJIHRoaW5rIHdlIHNob3VsZCB1c2UgYSBmZXcKPj4gZGlmZmVyZW50 IHRlc3RzLgo+IAo+IFNvb29vLCBiZW5jaG1hcmtpbmcgdGhlc2UgdHVybmVkIG91dCBhIGJpdCB0 cmlja2llciB0aGFuIEkgaGFkIGhvcGVkCj4gZm9yLiBBcHBhcmVudGx5LCBkaHJ5c3RvbmUgdXNl cyBhbiB1bnNpZ25lZCBpbnQgcmF0aGVyIHRoYW4gYW4KPiB1bnNpZ25lZCBsb25nIGZvciB0aGUg bG9vcHMgY291bnQgKG9yIHNvbWV0aGluZyBvZiB0aGF0IHNvcnQpLCB3aGljaAo+IG1lYW5zIHRo YXQgSSBjYW4ndCBnZXQgaXQgdG8gcnVuIGVub3VnaCBsb29wcyB0byBoZWF0IHVwIG15IGNoaXAg ZnJvbQo+IGEgc3RhYmxlIGlkbGUgc3RhdGUgdG8gdGhlIHRocm90dGxpbmcgc3RhdGUgKGR1ZSB0 byBjb3VudGVyCj4gd3JhcGFyb3VuZCkuIFNvIEkgZW5kZWQgdXAgd2l0aCBhIGNvdXBsZSBvZiBj cnV0Y2hlcywgbmFtZWx5OgoKSHVoLCBpdCBzZWVtcyB0aGF0IHJlY2VudCBTQkNzIG1heSBoYXZl IGJlY29tZSBhIGJpdCB0b28gZmFzdCBmb3IgaXQsCndoaWNoIGlzIGdyZWF0LiA6KSAgVGhhbmsg eW91IGZvciB0aGUgYmVuY2htYXJraW5nLgoKPiAgLSBydW4gZGhyeXN0b25lIGNvbnRpbnVvdXNs eSBvbiA2IG91dCBvZiA4IGNvcmVzIHRvIG1ha2UgdGhlIGNoaXAKPiB3YXJtIGVub3VnaCAoYHRh c2tzZXQgLWMgMC01IC4vZGhyeXN0b25lIC10IDYgLXIgNjAwMGAgLSBub3RlIHRoYXQgb24KPiBt eSBtYWNoaW5lIGNvcmVzIDYtNyBhcmUgdXN1YWxseSB0aGUgZmlyc3Qgb25lcyB0byBnZXQgdGhy b3R0bGVkLCBkdWUKPiB0byB3aGF0ZXZlciB0aGVybWFsIHBlY3VsaWFyaXRpZXMpCj4gIC0gd2Fp dCBmb3IgdGhlIHRlbXBlcmF0dXJlIHRvIHN0YWJpbGl6ZSAod2hpY2ggaGFwcGVucyBhdCA3OS41 QykKPiAgLSB0aGVuIHJ1biB0aW1lZCBkaHJ5c3RvbmUgb24gdGhlIHJlbWFpbmluZyAyIG91dCBv ZiA2IGNvcmVzIChiaWcKPiBvbmVzKSB0byBzZWUgaG93IHRocm90dGxpbmcgd2l0aCBkaWZmZXJl bnQgT1BQIHRhYmxlcyBhZmZlY3RzIG92ZXJhbGwKPiBwZXJmb3JtYW5jZS4KCkp1c3QgY2hlY2tp bmcsIHJ1bm5pbmcgdGhlIHRlc3Qgb24ganVzdCB0d28gQ1BVIGNvcmVzIHdhcyBlbm91Z2ggdG8K a2VlcCB0aGUgcGFja2FnZSB0ZW1wZXJhdHVyZSBhdCBhcm91bmQgODAgb0M/Cgo+IEluIHRoZSBl bmQsIGhlcmUncyB3aGF0IEkgZ290IHdpdGggdGhlICdvcmlnaW5hbCcgT1BQIHRhYmxlIChpbmNs dWRpbmcKPiAic2FtZSB2b2x0YWdlIC0gZGlmZmVyZW50IGZyZXF1ZW5jaWVzIiBzdGF0ZXMpOgo+ IGFsY2hhcmtAcm9jay01YiB+ICQgdGFza3NldCAtYyA2LTcgLi9kaHJ5c3RvbmUgLXQgMiAtbCA0 MDAwMDAwMDAwCj4gZHVyYXRpb246IDAgc2Vjb25kcwo+IG51bWJlciBvZiB0aHJlYWRzOiAyCj4g bnVtYmVyIG9mIGxvb3BzOiA0MDAwMDAwMDAwMDAwMDAwCj4gZGVsYXkgYmV0d2VlbiBzdGFydGlu ZyB0aHJlYWRzOiAwIHNlY29uZHMKPiAKPiBEaHJ5c3RvbmUoMS4xKSB0aW1lIGZvciAxMjMzOTc3 MzQ0IHBhc3NlcyA9IDI5LjcKPiBUaGlzIG1hY2hpbmUgYmVuY2htYXJrcyBhdCA0MTQ4MTUzOSBk aHJ5c3RvbmVzL3NlY29uZAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDIzNjA5IERNSVBT Cj4gRGhyeXN0b25lKDEuMSkgdGltZSBmb3IgMTIzMzk3NzM0NCBwYXNzZXMgPSAyOS44Cj4gVGhp cyBtYWNoaW5lIGJlbmNobWFya3MgYXQgNDE0NzY2MTggZGhyeXN0b25lcy9zZWNvbmQKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAyMzYwNiBETUlQUwo+IAo+IFRvdGFsIGRocnlzdG9uZSBy dW4gdGltZTogMzAuODY0NDkyIHNlY29uZHMuCj4gCj4gQW5kIGhlcmUncyB3aGF0IEkgZ290IHdp dGggdGhlICdyZWR1Y2VkJyBPUFAgdGFibGUgKGtlZXBpbmcgb25seSB0aGUKPiBoaWdoZXN0IGZy ZXF1ZW5jeSBzdGF0ZSBmb3IgZWFjaCB2b2x0YWdlKToKPiBhbGNoYXJrQHJvY2stNWIgfiAkIHRh c2tzZXQgLWMgNi03IC4vZGhyeXN0b25lIC10IDIgLWwgNDAwMDAwMDAwMAo+IGR1cmF0aW9uOiAw IHNlY29uZHMKPiBudW1iZXIgb2YgdGhyZWFkczogMgo+IG51bWJlciBvZiBsb29wczogNDAwMDAw MDAwMDAwMDAwMAo+IGRlbGF5IGJldHdlZW4gc3RhcnRpbmcgdGhyZWFkczogMCBzZWNvbmRzCj4g Cj4gRGhyeXN0b25lKDEuMSkgdGltZSBmb3IgMTIzMzk3NzM0NCBwYXNzZXMgPSAzMC45Cj4gVGhp cyBtYWNoaW5lIGJlbmNobWFya3MgYXQgMzk5Njg1NDkgZGhyeXN0b25lcy9zZWNvbmQKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgIDIyNzQ4IERNSVBTCj4gRGhyeXN0b25lKDEuMSkgdGltZSBm b3IgMTIzMzk3NzM0NCBwYXNzZXMgPSAzMS4wCj4gVGhpcyBtYWNoaW5lIGJlbmNobWFya3MgYXQg Mzk4MTc0MzEgZGhyeXN0b25lcy9zZWNvbmQKPiAgICAgICAgICAgICAgICAgICAgICAgICAgIDIy NjYyIERNSVBTCj4gCj4gVG90YWwgZGhyeXN0b25lIHJ1biB0aW1lOiAzMS45OTUxMzYgc2Vjb25k cy4KPiAKPiBCb3R0b21saW5lOiByZW1vdmluZyB0aGUgbG93ZXItZnJlcXVlbmN5IE9QUHMgbGVk IHRvIGEgMy44JSBkcm9wIGluCj4gcGVyZm9ybWFuY2UgaW4gdGhpcyBzZXR1cC4gVGhpcyBpcyBw cm9iYWJseSBmYXIgZnJvbSBhIHJlbGlhYmxlCj4gZXN0aW1hdGUsIGJ1dCBJIGd1ZXNzIGl0IGlu ZGVlZCBpbmRpY2F0ZXMgdGhhdCBoYXZpbmcgbG93ZXItZnJlcXVlbmN5Cj4gc3RhdGVzIG1pZ2h0 IGJlIGJlbmVmaWNpYWwgaW4gc29tZSBsb2FkIHNjZW5hcmlvcy4KCk1lYXN1cmluZyBhIGRpZmZl cmVuY2Ugb2YgYWJvdXQgNCUgbWF5IGJlIGF0dHJpYnV0ZWQgdG8gc29tZSB1bmtub3duCmluYWNj dXJhY3kgb3IgdGVzdCBkZXZpYXRpb24sIGJ1dCBhZ2FpbiwgYSBwZXJmb3JtYW5jZSBpbXByb3Zl bWVudCBvZgphYm91dCA0JSB0aGF0IGNvbWVzIGZyZWUgb2YgY2hhcmdlIGlzIG5vdGhpbmcgdG8g YmUgc25lZXplZCBhdCwgSU1ITy4KCj4gTm90ZSB0aG91Z2ggdGhhdCBzZXZlcmFsIHNlY29uZHMg YWZ0ZXIgaGl0dGluZyB0aGUgdGhyb3R0bGluZwo+IHRocmVzaG9sZCBjb3JlcyA2LTcgd2VyZSBv c2NpbGxhdGluZyBiZXR3ZWVuIDEuNjA4R0h6IGFuZCAxLjhHSHogaW4KPiBib3RoIHJ1bnMsIHdo aWNoIGltcGxpZXMgdGhhdCB0aGUgd2hvbGUgZGlmZmVyZW5jZSBpbiBwZXJmb3JtYW5jZSB3YXMK PiBkdWUgdG8gZGlmZmVyZW50IHNwZWVkIG9mIGluaXRpYWwgdGhyb3R0bGluZyAoaS5lLiBpdCBt aWdodCBiZSBhCj4gcGVjdWxpYXJpdHkgb2YgdGhlIHN0ZXAtd2lzZSB0aGVybWFsIGdvdmVybm9y IG9wZXJhdGlvbiB3aGVuIGl0IGhhcyB0bwo+IGdvIHRocm91Z2ggbW9yZSBjb29saW5nIHN0YXRl cyB0byByZWFjaCB0aGUgInN0ZWFkeS1zdGF0ZSIgb25lKS4gR2l2ZW4KPiB0aGF0IGJvdGggMS42 MDhHSHogYW5kIDEuOEdIeiBoYXZlIG5vIGxvd2VyLWZyZXF1ZW5jeSBzYW1lLXZvbHRhZ2UKPiBz aWJsaW5ncyBpbiBlaXRoZXIgb2YgdGhlIE9QUCB0YWJsZXMsIGl0IGltcGxpZXMgdGhhdCB1bmRl ciBwcm9sb25nZWQKPiBjb25zdGFudCBsb2FkIHRoZXJlIHNob3VsZCBiZSBubyBwZXJmb3JtYW5j ZSBkaWZmZXJlbmNlIGF0IGFsbC4KCi4uLiBhbGwgdGhhdCB3aXRoIG9uZSBwb3NzaWJsZSBjb29s aW5nIHNldHVwLCBhbmQgd2l0aCBvbmUgc3ludGhldGljCnRlc3QuICBXZSBzaW1wbHkgY2FuJ3Qg a25vdyBpbiBhZHZhbmNlIGhvdyB3b3VsZCBhIGRpZmZlcmVudCBjb29saW5nCnNldHVwIG9uIHRo ZSBzYW1lIG9yIG9uIGEgZGlmZmVyZW50IGJvYXJkIGJlaGF2ZSwgaWYgeW91IGFncmVlLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2No aXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80E3BC48285 for ; Sun, 28 Jan 2024 03:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lK2Dy1PI0VJd6Sle7XWfnLcdKiRrEIY1TRtEbOLQuKQ=; b=Oun5BPegA6LkYcIeM/zEtmI/7W IOFhK/J3vqLcUH/toqKiuKyWKZe0fwo3wevVRmH+jQVJXm8AGWRjkyexJtm236vmE01gpRhIWP3P8 CBJhVP7RXaehgRAENf87VoC0RQ8TzL2OpKeo6QAAcVP/skUHpXSqEB2U1OhoIl/yng8+J/2zLY2gr MThiMxlwAXPzLA+TBjZkakuoGMiKPETIeY5yPAaFmG+MstAep+Z0cqQeZM9WRlgb5qJ9ZVoF6C16i jlXdiHVX/be+Onz6G74iUIQsV1spugoH12ILCtJ5e8qe7R+EFZpqfDbLtHseBrZaU2VpsWG/y74AV Hn14elJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTvxs-00000008ept-2neV; Sun, 28 Jan 2024 03:36:12 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTvxn-00000008eoe-0EcQ; Sun, 28 Jan 2024 03:36:10 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1706412958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGynTAOYEGgnqBwfLRvahiiezGVmO/RYQ5/JRIx6Ctk=; b=KG6rScrRZHwd6CM0HJJfXU/XWE00HNFc5rAeAejlPdmECoKkqpbO62Qeqy2q9DNE9cgk9g P9io/r1zWzHMvU6jV6jd32bXQecZALlr61VkUpTB/5GQ2ye5R8Q4fOdg29UXOc/LtNLcup DasNWw3fAqWceknmDXZHUp/OaSdniHAmUluORsO6YZvv/5FksGr6k5JTBgfYjUyZJckAH8 VNa17VsMXlMhKqg4XfYGkhP+H+5Q595YPnsmv+odGHio5qtz8SlX/gJ56i2zKTF7lT8HiM 77ORaZwK7M77FpFPPJzoOA6X4MAquOIRGWP67I5YXk20m+vMBt7JIA0TsIUBPQ== Date: Sun, 28 Jan 2024 04:35:58 +0100 From: Dragan Simic To: Alexey Charkov Cc: Daniel Lezcano , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Viresh Kumar Subject: Re: [PATCH 4/4] arm64: dts: rockchip: Add OPP data for CPU cores on RK3588 In-Reply-To: References: <20240125-rk-dts-additions-v1-0-5879275db36f@gmail.com> <20240125-rk-dts-additions-v1-4-5879275db36f@gmail.com> <731aac66-f698-4a1e-b9ee-46a7f24ecae5@linaro.org> <1f0608831cfb95c80edf16cd751eee76@manjaro.org> <528a37d84cdd871e717b4ebf648bb8a7@manjaro.org> <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> <5ef9bab979260884866efe30d19ba8f1@manjaro.org> Message-ID: <9fda41efe365241ce06bd58974c8e055@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_193607_773230_70F5CBFC X-CRM114-Status: GOOD ( 42.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMS0yNyAyMDo0MSwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gU2F0LCBKYW4g MjcsIDIwMjQgYXQgMTI6MzPigK9BTSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJvLm9yZz4g Cj4gd3JvdGU6Cj4+IE9uIDIwMjQtMDEtMjYgMTQ6NDQsIEFsZXhleSBDaGFya292IHdyb3RlOgo+ PiA+IE9uIEZyaSwgSmFuIDI2LCAyMDI0IGF0IDQ6NTbigK9QTSBEYW5pZWwgTGV6Y2FubyA8ZGFu aWVsLmxlemNhbm9AbGluYXJvLm9yZz4gd3JvdGU6Cj4+ID4+IE9uIDI2LzAxLzIwMjQgMDg6NDks IERyYWdhbiBTaW1pYyB3cm90ZToKPj4gPj4gPiBPbiAyMDI0LTAxLTI2IDA4OjMwLCBBbGV4ZXkg Q2hhcmtvdiB3cm90ZToKPj4gPj4gPj4gT24gRnJpLCBKYW4gMjYsIDIwMjQgYXQgMTE6MDXigK9B TSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJvLm9yZz4gd3JvdGU6Cj4+ID4+ID4+PiBPbiAy MDI0LTAxLTI2IDA3OjQ0LCBBbGV4ZXkgQ2hhcmtvdiB3cm90ZToKPj4gPj4gPj4+ID4gT24gRnJp LCBKYW4gMjYsIDIwMjQgYXQgMTA6MzLigK9BTSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJv Lm9yZz4gd3JvdGU6Cj4+ID4+ID4+PiA+PiBPbiAyMDI0LTAxLTI1IDEwOjMwLCBEYW5pZWwgTGV6 Y2FubyB3cm90ZToKPj4gPj4gPj4gVGhyb3R0bGluZyB3b3VsZCBhbHNvIGxvd2VyIHRoZSB2b2x0 YWdlIGF0IHNvbWUgcG9pbnQsIHdoaWNoIGNvb2xzIGl0Cj4+ID4+ID4+IGRvd24gbXVjaCBmYXN0 ZXIhCj4+ID4+ID4KPj4gPj4gPiBPZiBjb3Vyc2UsIGJ1dCB0aGUga2V5IGlzIG5vdCB0byBjb29s IChhbmQgc2xvdyBkb3duKSB0aGUgQ1BVIGNvcmVzIHRvbwo+PiA+PiA+IG11Y2gsIGJ1dCBqdXN0 IGVub3VnaCB0byBzdGF5IHdpdGhpbiB0aGUgYXZhaWxhYmxlIHRoZXJtYWwgZW52ZWxvcGUsCj4+ ID4+ID4gd2hpY2ggaXMgd2hlcmUgdGhlIHNhbWUtdm9sdGFnZSwgbG93ZXItZnJlcXVlbmN5IE9Q UHMgc2hvdWxkIHNoaW5lLgo+PiA+Pgo+PiA+PiBUaGF0IGltcGxpZXMgdGhlIHJlc3VsdGluZyBw b3dlciBpcyBzdXN0YWluYWJsZSB3aGljaCBJIGRvdWJ0IGl0IGlzCj4+ID4+IHRoZQo+PiA+PiBj YXNlLgo+PiA+Pgo+PiA+PiBUaGUgdm9sdGFnZSBzY2FsaW5nIG1ha2VzIHRoZSBjb29saW5nIGVm ZmVjdCBlZmZpY2llbnQgbm90IHRoZQo+PiA+PiBmcmVxdWVuY3kuCj4+ID4+Cj4+ID4+IEZvciBl eGFtcGxlOgo+PiA+PiAgICAgICAgIG9wcDUgPSBvcHAoMkdIeiwgMVYpID0+IDIgQm9nb1dhdHQK Pj4gPj4gICAgICAgICBvcHA0ID0gb3BwKDEuOUdIeiwgMVYpID0+IDEuOSBCb2dvV2F0dAo+PiA+ PiAgICAgICAgIG9wcDMgPSBvcHAoMS44R0h6LCAwLjlWKSA9PiAxLjQ1OCBCb2dvV2F0dAo+PiA+ PiAgICAgICAgIFsgb3RoZXIgc3RhdGVzIGJ1dCB3ZSBmb2N1cyBvbiB0aGVzZSAzIF0KPj4gPj4K Pj4gPj4gb3BwNS0+b3BwNCA9PiAtNSUgY29tcHV0ZSBjYXBhY2l0eSwgLTUlIHBvd2VyLCByYXRp bz0xCj4+ID4+IG9wcDQtPm9wcDMgPT4gLTUlIGNvbXB1dGUgY2FwYWNpdHksIC0yMy4xJSBwb3dl ciwgcmF0aW89MjEsNgo+PiA+Pgo+PiA+PiBvcHA1LT5vcHAzID0+IC0xMCUgY29tcHV0ZSBjYXBh Y2l0eSwgLTI3LjElIHBvd2VyLCByYXRpbz0zNi45Cj4+ID4+Cj4+ID4+IEluIGJ1cnN0IG9wZXJh dGlvbiAobm8gdGhlcm1hbCB0aHJvdHRsaW5nKSwgb3BwNCBpcyBwb2ludGxlc3Mgd2UgYWdyZWUK Pj4gPj4gb24gdGhhdC4KPj4gPj4KPj4gPj4gSU1PIHRoZSBmb2xsb3dpbmcgd2lsbCBoYXBwZW46 IGluIGJ1cnN0IG9wZXJhdGlvbiB3aXRoIHRoZXJtYWwKPj4gPj4gdGhyb3R0bGluZyB3ZSBoaXQg dGhlIHRyaXAgcG9pbnQgYW5kIHRoZW4gdGhlIHN0ZXAgd2lzZSBnb3Zlcm5vcgo+PiA+PiByZWR1 Y2VzCj4+ID4+IG9wcDUgLT4gb3BwNC4gV2UgaGF2ZSBzbGlnaHQgcG93ZXIgcmVkdWN0aW9uIGJ1 dCB0aGUgdGVtcGVyYXR1cmUgZG9lcwo+PiA+PiBub3QgZGVjcmVhc2UsIHNvIGF0IHRoZSBuZXh0 IGl0ZXJhdGlvbiwgaXQgaXMgdGhyb3R0bGUgYXQgb3BwMy4gQW5kIGF0Cj4+ID4+IHRoZSBlbmQg d2UgaGF2ZSBvcHA0IDwtPiBvcHAzIGJhY2sgYW5kIGZvcnRoIGluc3RlYWQgb2Ygb3BwNSA8LT4g b3BwMy4KPj4gPj4KPj4gPj4gSXQgaXMgcHJvYmFibGUgd2UgZW5kIHVwIHdpdGggYW4gZXF1aXZh bGVudCBmcmVxdWVuY3kgYXZlcmFnZSAob3IKPj4gPj4gY29tcHV0ZSBjYXBhY2l0eSBhdmcpLgo+ PiA+Pgo+PiA+PiBvcHA0IDwtPiBvcHAzIChsb25nZXIgZHVyYXRpb24gaW4gc3RhdGVzLCBsZXNz IHRyYW5zaXRpb25zKQo+PiA+PiBvcHA1IDwtPiBvcHAzIChzaG9ydGVyIGR1cmF0aW9uIGluIHN0 YXRlcywgbW9yZSB0cmFuc2l0aW9ucykKPj4gPj4KPj4gPj4gU29tZSBwbGF0Zm9ybXMgaGFkIHRo ZWlyIGhpZ2hlciBPUFBzIHdpdGggdGhlIHNhbWUgdm9sdGFnZSBhbmQgdGhleQo+PiA+PiBmYWls ZWQgdG8gY29vbCBkb3duIHRoZSBDUFUgaW4gdGhlIGxvbmcgcnVuLgo+PiA+Pgo+PiA+PiBBbnl3 YXksIHRoZXJlIGlzIG9ubHkgb25lIHdheSB0byBjaGVjayBpdCBvdXQgOikKPj4gPj4KPj4gPj4g QWxleGV5LCBpcyBpdCBwb3NzaWJsZSB0byBjb21wYXJlIHRoZSBjb21wdXRlIGR1cmF0aW9uIGZv ciAnZGhyeXN0b25lJwo+PiA+PiB3aXRoIHRoZXNlIHZvbHRhZ2UgT1BQIGFuZCB3aXRob3V0ID8g KHdpdGggYSBwZXJpb2Qgb2YgY29vbCBkb3duCj4+ID4+IGJldHdlZW4KPj4gPj4gdGhlIHRlc3Qg aW4gb3JkZXIgdG8gc3RhcnQgYXQgdGhlIHNhbWUgdGhlcm1hbCBjb25kaXRpb24pID8KPj4gPgo+ PiA+IFN1cmUsIGxldCBtZSB0cnkgdGhhdCAtIHdvdWxkIGJlIGludGVyZXN0aW5nIHRvIHNlZSB0 aGUgcmVzdWx0cy4gSW4gbXkKPj4gPiBwcmV2aW91cyB0aW5rZXJpbmcgdGhlcmUgd2VyZSBjYXNl cyB3aGVuIHRoZSBzeXN0ZW0gc3RheWVkIGF0IDIuMzVHSHoKPj4gPiBmb3IgYWxsIGJpZyBjb3Jl cyBmb3Igbm9uLXRyaXZpYWwgdGltZSAodXNpbmcgdGhlIHN0ZXAtd2lzZSB0aGVybWFsCj4+ID4g Z292ZXJub3IpLCBhbmQgdGhhdCdzIGFuIGV4YW1wbGUgb2YgInNhbWUgdm9sdGFnZSwgbG93ZXIg ZnJlcXVlbmN5Ii4KPj4gPiBPdGhlciB0aW1lcyB0aG91Z2ggaXQgdGhyb3R0bGVkIG9uZSBjbHVz dGVyIGRvd24gdG8gMS44R0h6IGFuZCBrZXB0Cj4+ID4gdGhlIG90aGVyIGF0IDIuNEdIeiwgYW5k IHdhcyBhbHNvIHN0YXRpb25hcnkgYXQgdGhvc2UgcGFyYW1ldGVycyBmb3IKPj4gPiBleHRlbmRl ZCB0aW1lLiBUaGlzIHByb2JhYmx5IGluZGljYXRlcyB0aGF0IGJvdGggb2YgdGhvc2Ugc3RhdGVz IHVzZQo+PiA+IHN1c3RhaW5hYmxlIHBvd2VyIGluIG15IGNvb2xpbmcgc2V0dXAuCj4+IAo+PiBJ TUhPLCB0aGVyZSBhcmUgc2ltcGx5IHRvbyBtYW55IGZhY3RvcnMgYXQgcGxheSwgaW5jbHVkaW5n IGRpZmZlcmVudAo+PiBwb3NzaWJsZSBjb29saW5nIHNldHVwcywgc28gcHJvdmlkaW5nIGFkZGl0 aW9uYWwgQ1BVIHRocm90dGxpbmcKPj4gZ3JhbnVsYXJpdHkgY2FuIG9ubHkgYmUgaGVscGZ1bC4g IE9mIGNvdXJzZSwgdGVzdGluZyBhbmQgcmVjb3JkaW5nCj4+IGRhdGEgaXMgdGhlIHdheSB0byBt b3ZlIGZvcndhcmQsIGJ1dCBJIHRoaW5rIHdlIHNob3VsZCB1c2UgYSBmZXcKPj4gZGlmZmVyZW50 IHRlc3RzLgo+IAo+IFNvb29vLCBiZW5jaG1hcmtpbmcgdGhlc2UgdHVybmVkIG91dCBhIGJpdCB0 cmlja2llciB0aGFuIEkgaGFkIGhvcGVkCj4gZm9yLiBBcHBhcmVudGx5LCBkaHJ5c3RvbmUgdXNl cyBhbiB1bnNpZ25lZCBpbnQgcmF0aGVyIHRoYW4gYW4KPiB1bnNpZ25lZCBsb25nIGZvciB0aGUg bG9vcHMgY291bnQgKG9yIHNvbWV0aGluZyBvZiB0aGF0IHNvcnQpLCB3aGljaAo+IG1lYW5zIHRo YXQgSSBjYW4ndCBnZXQgaXQgdG8gcnVuIGVub3VnaCBsb29wcyB0byBoZWF0IHVwIG15IGNoaXAg ZnJvbQo+IGEgc3RhYmxlIGlkbGUgc3RhdGUgdG8gdGhlIHRocm90dGxpbmcgc3RhdGUgKGR1ZSB0 byBjb3VudGVyCj4gd3JhcGFyb3VuZCkuIFNvIEkgZW5kZWQgdXAgd2l0aCBhIGNvdXBsZSBvZiBj cnV0Y2hlcywgbmFtZWx5OgoKSHVoLCBpdCBzZWVtcyB0aGF0IHJlY2VudCBTQkNzIG1heSBoYXZl IGJlY29tZSBhIGJpdCB0b28gZmFzdCBmb3IgaXQsCndoaWNoIGlzIGdyZWF0LiA6KSAgVGhhbmsg eW91IGZvciB0aGUgYmVuY2htYXJraW5nLgoKPiAgLSBydW4gZGhyeXN0b25lIGNvbnRpbnVvdXNs eSBvbiA2IG91dCBvZiA4IGNvcmVzIHRvIG1ha2UgdGhlIGNoaXAKPiB3YXJtIGVub3VnaCAoYHRh c2tzZXQgLWMgMC01IC4vZGhyeXN0b25lIC10IDYgLXIgNjAwMGAgLSBub3RlIHRoYXQgb24KPiBt eSBtYWNoaW5lIGNvcmVzIDYtNyBhcmUgdXN1YWxseSB0aGUgZmlyc3Qgb25lcyB0byBnZXQgdGhy b3R0bGVkLCBkdWUKPiB0byB3aGF0ZXZlciB0aGVybWFsIHBlY3VsaWFyaXRpZXMpCj4gIC0gd2Fp dCBmb3IgdGhlIHRlbXBlcmF0dXJlIHRvIHN0YWJpbGl6ZSAod2hpY2ggaGFwcGVucyBhdCA3OS41 QykKPiAgLSB0aGVuIHJ1biB0aW1lZCBkaHJ5c3RvbmUgb24gdGhlIHJlbWFpbmluZyAyIG91dCBv ZiA2IGNvcmVzIChiaWcKPiBvbmVzKSB0byBzZWUgaG93IHRocm90dGxpbmcgd2l0aCBkaWZmZXJl bnQgT1BQIHRhYmxlcyBhZmZlY3RzIG92ZXJhbGwKPiBwZXJmb3JtYW5jZS4KCkp1c3QgY2hlY2tp bmcsIHJ1bm5pbmcgdGhlIHRlc3Qgb24ganVzdCB0d28gQ1BVIGNvcmVzIHdhcyBlbm91Z2ggdG8K a2VlcCB0aGUgcGFja2FnZSB0ZW1wZXJhdHVyZSBhdCBhcm91bmQgODAgb0M/Cgo+IEluIHRoZSBl bmQsIGhlcmUncyB3aGF0IEkgZ290IHdpdGggdGhlICdvcmlnaW5hbCcgT1BQIHRhYmxlIChpbmNs dWRpbmcKPiAic2FtZSB2b2x0YWdlIC0gZGlmZmVyZW50IGZyZXF1ZW5jaWVzIiBzdGF0ZXMpOgo+ IGFsY2hhcmtAcm9jay01YiB+ICQgdGFza3NldCAtYyA2LTcgLi9kaHJ5c3RvbmUgLXQgMiAtbCA0 MDAwMDAwMDAwCj4gZHVyYXRpb246IDAgc2Vjb25kcwo+IG51bWJlciBvZiB0aHJlYWRzOiAyCj4g bnVtYmVyIG9mIGxvb3BzOiA0MDAwMDAwMDAwMDAwMDAwCj4gZGVsYXkgYmV0d2VlbiBzdGFydGlu ZyB0aHJlYWRzOiAwIHNlY29uZHMKPiAKPiBEaHJ5c3RvbmUoMS4xKSB0aW1lIGZvciAxMjMzOTc3 MzQ0IHBhc3NlcyA9IDI5LjcKPiBUaGlzIG1hY2hpbmUgYmVuY2htYXJrcyBhdCA0MTQ4MTUzOSBk aHJ5c3RvbmVzL3NlY29uZAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDIzNjA5IERNSVBT Cj4gRGhyeXN0b25lKDEuMSkgdGltZSBmb3IgMTIzMzk3NzM0NCBwYXNzZXMgPSAyOS44Cj4gVGhp cyBtYWNoaW5lIGJlbmNobWFya3MgYXQgNDE0NzY2MTggZGhyeXN0b25lcy9zZWNvbmQKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAyMzYwNiBETUlQUwo+IAo+IFRvdGFsIGRocnlzdG9uZSBy dW4gdGltZTogMzAuODY0NDkyIHNlY29uZHMuCj4gCj4gQW5kIGhlcmUncyB3aGF0IEkgZ290IHdp dGggdGhlICdyZWR1Y2VkJyBPUFAgdGFibGUgKGtlZXBpbmcgb25seSB0aGUKPiBoaWdoZXN0IGZy ZXF1ZW5jeSBzdGF0ZSBmb3IgZWFjaCB2b2x0YWdlKToKPiBhbGNoYXJrQHJvY2stNWIgfiAkIHRh c2tzZXQgLWMgNi03IC4vZGhyeXN0b25lIC10IDIgLWwgNDAwMDAwMDAwMAo+IGR1cmF0aW9uOiAw IHNlY29uZHMKPiBudW1iZXIgb2YgdGhyZWFkczogMgo+IG51bWJlciBvZiBsb29wczogNDAwMDAw MDAwMDAwMDAwMAo+IGRlbGF5IGJldHdlZW4gc3RhcnRpbmcgdGhyZWFkczogMCBzZWNvbmRzCj4g Cj4gRGhyeXN0b25lKDEuMSkgdGltZSBmb3IgMTIzMzk3NzM0NCBwYXNzZXMgPSAzMC45Cj4gVGhp cyBtYWNoaW5lIGJlbmNobWFya3MgYXQgMzk5Njg1NDkgZGhyeXN0b25lcy9zZWNvbmQKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgIDIyNzQ4IERNSVBTCj4gRGhyeXN0b25lKDEuMSkgdGltZSBm b3IgMTIzMzk3NzM0NCBwYXNzZXMgPSAzMS4wCj4gVGhpcyBtYWNoaW5lIGJlbmNobWFya3MgYXQg Mzk4MTc0MzEgZGhyeXN0b25lcy9zZWNvbmQKPiAgICAgICAgICAgICAgICAgICAgICAgICAgIDIy NjYyIERNSVBTCj4gCj4gVG90YWwgZGhyeXN0b25lIHJ1biB0aW1lOiAzMS45OTUxMzYgc2Vjb25k cy4KPiAKPiBCb3R0b21saW5lOiByZW1vdmluZyB0aGUgbG93ZXItZnJlcXVlbmN5IE9QUHMgbGVk IHRvIGEgMy44JSBkcm9wIGluCj4gcGVyZm9ybWFuY2UgaW4gdGhpcyBzZXR1cC4gVGhpcyBpcyBw cm9iYWJseSBmYXIgZnJvbSBhIHJlbGlhYmxlCj4gZXN0aW1hdGUsIGJ1dCBJIGd1ZXNzIGl0IGlu ZGVlZCBpbmRpY2F0ZXMgdGhhdCBoYXZpbmcgbG93ZXItZnJlcXVlbmN5Cj4gc3RhdGVzIG1pZ2h0 IGJlIGJlbmVmaWNpYWwgaW4gc29tZSBsb2FkIHNjZW5hcmlvcy4KCk1lYXN1cmluZyBhIGRpZmZl cmVuY2Ugb2YgYWJvdXQgNCUgbWF5IGJlIGF0dHJpYnV0ZWQgdG8gc29tZSB1bmtub3duCmluYWNj dXJhY3kgb3IgdGVzdCBkZXZpYXRpb24sIGJ1dCBhZ2FpbiwgYSBwZXJmb3JtYW5jZSBpbXByb3Zl bWVudCBvZgphYm91dCA0JSB0aGF0IGNvbWVzIGZyZWUgb2YgY2hhcmdlIGlzIG5vdGhpbmcgdG8g YmUgc25lZXplZCBhdCwgSU1ITy4KCj4gTm90ZSB0aG91Z2ggdGhhdCBzZXZlcmFsIHNlY29uZHMg YWZ0ZXIgaGl0dGluZyB0aGUgdGhyb3R0bGluZwo+IHRocmVzaG9sZCBjb3JlcyA2LTcgd2VyZSBv c2NpbGxhdGluZyBiZXR3ZWVuIDEuNjA4R0h6IGFuZCAxLjhHSHogaW4KPiBib3RoIHJ1bnMsIHdo aWNoIGltcGxpZXMgdGhhdCB0aGUgd2hvbGUgZGlmZmVyZW5jZSBpbiBwZXJmb3JtYW5jZSB3YXMK PiBkdWUgdG8gZGlmZmVyZW50IHNwZWVkIG9mIGluaXRpYWwgdGhyb3R0bGluZyAoaS5lLiBpdCBt aWdodCBiZSBhCj4gcGVjdWxpYXJpdHkgb2YgdGhlIHN0ZXAtd2lzZSB0aGVybWFsIGdvdmVybm9y IG9wZXJhdGlvbiB3aGVuIGl0IGhhcyB0bwo+IGdvIHRocm91Z2ggbW9yZSBjb29saW5nIHN0YXRl cyB0byByZWFjaCB0aGUgInN0ZWFkeS1zdGF0ZSIgb25lKS4gR2l2ZW4KPiB0aGF0IGJvdGggMS42 MDhHSHogYW5kIDEuOEdIeiBoYXZlIG5vIGxvd2VyLWZyZXF1ZW5jeSBzYW1lLXZvbHRhZ2UKPiBz aWJsaW5ncyBpbiBlaXRoZXIgb2YgdGhlIE9QUCB0YWJsZXMsIGl0IGltcGxpZXMgdGhhdCB1bmRl ciBwcm9sb25nZWQKPiBjb25zdGFudCBsb2FkIHRoZXJlIHNob3VsZCBiZSBubyBwZXJmb3JtYW5j ZSBkaWZmZXJlbmNlIGF0IGFsbC4KCi4uLiBhbGwgdGhhdCB3aXRoIG9uZSBwb3NzaWJsZSBjb29s aW5nIHNldHVwLCBhbmQgd2l0aCBvbmUgc3ludGhldGljCnRlc3QuICBXZSBzaW1wbHkgY2FuJ3Qg a25vdyBpbiBhZHZhbmNlIGhvdyB3b3VsZCBhIGRpZmZlcmVudCBjb29saW5nCnNldHVwIG9uIHRo ZSBzYW1lIG9yIG9uIGEgZGlmZmVyZW50IGJvYXJkIGJlaGF2ZSwgaWYgeW91IGFncmVlLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D30903FEF; Sun, 28 Jan 2024 03:36:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706412970; cv=none; b=XRsUcSRGZAxpxEXxMGo+5OGNa5rTx5equrBT4VXtAAzp39RKuDf223gwDq9hGf0HCDwPzsc+lHbzNKONMb1cQpRF5QB61pfKrrMJf5+7e8REshzSAkHi3wUlUCQg10g7ptloW6YsMln0xq4McfeC+v15T/c5zmbOEwb4bo7b9dY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706412970; c=relaxed/simple; bh=KYQFlIIyPOnAYU4BCpmcqOZW2Fk66y/U3GkF/Ses4e8=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=QCg/Ut2cbi2V1owaLm6JIKWrQ0x+PpCgFjcvDv77D34YBNwGt6KoB+qOpvbcU510DBF53Y5pSRdViyJ6oY4NRJBFldrjDzMq1XLYHl4ggZXDJ7EJI+rsrWGpM6SBxWD6NKx773rMIufPR1i2pXIg6uOxAGn0GKBjut8/vGICMkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=KG6rScrR; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="KG6rScrR" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1706412958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGynTAOYEGgnqBwfLRvahiiezGVmO/RYQ5/JRIx6Ctk=; b=KG6rScrRZHwd6CM0HJJfXU/XWE00HNFc5rAeAejlPdmECoKkqpbO62Qeqy2q9DNE9cgk9g P9io/r1zWzHMvU6jV6jd32bXQecZALlr61VkUpTB/5GQ2ye5R8Q4fOdg29UXOc/LtNLcup DasNWw3fAqWceknmDXZHUp/OaSdniHAmUluORsO6YZvv/5FksGr6k5JTBgfYjUyZJckAH8 VNa17VsMXlMhKqg4XfYGkhP+H+5Q595YPnsmv+odGHio5qtz8SlX/gJ56i2zKTF7lT8HiM 77ORaZwK7M77FpFPPJzoOA6X4MAquOIRGWP67I5YXk20m+vMBt7JIA0TsIUBPQ== Date: Sun, 28 Jan 2024 04:35:58 +0100 From: Dragan Simic To: Alexey Charkov Cc: Daniel Lezcano , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Viresh Kumar Subject: Re: [PATCH 4/4] arm64: dts: rockchip: Add OPP data for CPU cores on RK3588 In-Reply-To: References: <20240125-rk-dts-additions-v1-0-5879275db36f@gmail.com> <20240125-rk-dts-additions-v1-4-5879275db36f@gmail.com> <731aac66-f698-4a1e-b9ee-46a7f24ecae5@linaro.org> <1f0608831cfb95c80edf16cd751eee76@manjaro.org> <528a37d84cdd871e717b4ebf648bb8a7@manjaro.org> <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> <5ef9bab979260884866efe30d19ba8f1@manjaro.org> Message-ID: <9fda41efe365241ce06bd58974c8e055@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-01-27 20:41, Alexey Charkov wrote: > On Sat, Jan 27, 2024 at 12:33 AM Dragan Simic > wrote: >> On 2024-01-26 14:44, Alexey Charkov wrote: >> > On Fri, Jan 26, 2024 at 4:56 PM Daniel Lezcano wrote: >> >> On 26/01/2024 08:49, Dragan Simic wrote: >> >> > On 2024-01-26 08:30, Alexey Charkov wrote: >> >> >> On Fri, Jan 26, 2024 at 11:05 AM Dragan Simic wrote: >> >> >>> On 2024-01-26 07:44, Alexey Charkov wrote: >> >> >>> > On Fri, Jan 26, 2024 at 10:32 AM Dragan Simic wrote: >> >> >>> >> On 2024-01-25 10:30, Daniel Lezcano wrote: >> >> >> Throttling would also lower the voltage at some point, which cools it >> >> >> down much faster! >> >> > >> >> > Of course, but the key is not to cool (and slow down) the CPU cores too >> >> > much, but just enough to stay within the available thermal envelope, >> >> > which is where the same-voltage, lower-frequency OPPs should shine. >> >> >> >> That implies the resulting power is sustainable which I doubt it is >> >> the >> >> case. >> >> >> >> The voltage scaling makes the cooling effect efficient not the >> >> frequency. >> >> >> >> For example: >> >> opp5 = opp(2GHz, 1V) => 2 BogoWatt >> >> opp4 = opp(1.9GHz, 1V) => 1.9 BogoWatt >> >> opp3 = opp(1.8GHz, 0.9V) => 1.458 BogoWatt >> >> [ other states but we focus on these 3 ] >> >> >> >> opp5->opp4 => -5% compute capacity, -5% power, ratio=1 >> >> opp4->opp3 => -5% compute capacity, -23.1% power, ratio=21,6 >> >> >> >> opp5->opp3 => -10% compute capacity, -27.1% power, ratio=36.9 >> >> >> >> In burst operation (no thermal throttling), opp4 is pointless we agree >> >> on that. >> >> >> >> IMO the following will happen: in burst operation with thermal >> >> throttling we hit the trip point and then the step wise governor >> >> reduces >> >> opp5 -> opp4. We have slight power reduction but the temperature does >> >> not decrease, so at the next iteration, it is throttle at opp3. And at >> >> the end we have opp4 <-> opp3 back and forth instead of opp5 <-> opp3. >> >> >> >> It is probable we end up with an equivalent frequency average (or >> >> compute capacity avg). >> >> >> >> opp4 <-> opp3 (longer duration in states, less transitions) >> >> opp5 <-> opp3 (shorter duration in states, more transitions) >> >> >> >> Some platforms had their higher OPPs with the same voltage and they >> >> failed to cool down the CPU in the long run. >> >> >> >> Anyway, there is only one way to check it out :) >> >> >> >> Alexey, is it possible to compare the compute duration for 'dhrystone' >> >> with these voltage OPP and without ? (with a period of cool down >> >> between >> >> the test in order to start at the same thermal condition) ? >> > >> > Sure, let me try that - would be interesting to see the results. In my >> > previous tinkering there were cases when the system stayed at 2.35GHz >> > for all big cores for non-trivial time (using the step-wise thermal >> > governor), and that's an example of "same voltage, lower frequency". >> > Other times though it throttled one cluster down to 1.8GHz and kept >> > the other at 2.4GHz, and was also stationary at those parameters for >> > extended time. This probably indicates that both of those states use >> > sustainable power in my cooling setup. >> >> IMHO, there are simply too many factors at play, including different >> possible cooling setups, so providing additional CPU throttling >> granularity can only be helpful. Of course, testing and recording >> data is the way to move forward, but I think we should use a few >> different tests. > > Soooo, benchmarking these turned out a bit trickier than I had hoped > for. Apparently, dhrystone uses an unsigned int rather than an > unsigned long for the loops count (or something of that sort), which > means that I can't get it to run enough loops to heat up my chip from > a stable idle state to the throttling state (due to counter > wraparound). So I ended up with a couple of crutches, namely: Huh, it seems that recent SBCs may have become a bit too fast for it, which is great. :) Thank you for the benchmarking. > - run dhrystone continuously on 6 out of 8 cores to make the chip > warm enough (`taskset -c 0-5 ./dhrystone -t 6 -r 6000` - note that on > my machine cores 6-7 are usually the first ones to get throttled, due > to whatever thermal peculiarities) > - wait for the temperature to stabilize (which happens at 79.5C) > - then run timed dhrystone on the remaining 2 out of 6 cores (big > ones) to see how throttling with different OPP tables affects overall > performance. Just checking, running the test on just two CPU cores was enough to keep the package temperature at around 80 oC? > In the end, here's what I got with the 'original' OPP table (including > "same voltage - different frequencies" states): > alchark@rock-5b ~ $ taskset -c 6-7 ./dhrystone -t 2 -l 4000000000 > duration: 0 seconds > number of threads: 2 > number of loops: 4000000000000000 > delay between starting threads: 0 seconds > > Dhrystone(1.1) time for 1233977344 passes = 29.7 > This machine benchmarks at 41481539 dhrystones/second > 23609 DMIPS > Dhrystone(1.1) time for 1233977344 passes = 29.8 > This machine benchmarks at 41476618 dhrystones/second > 23606 DMIPS > > Total dhrystone run time: 30.864492 seconds. > > And here's what I got with the 'reduced' OPP table (keeping only the > highest frequency state for each voltage): > alchark@rock-5b ~ $ taskset -c 6-7 ./dhrystone -t 2 -l 4000000000 > duration: 0 seconds > number of threads: 2 > number of loops: 4000000000000000 > delay between starting threads: 0 seconds > > Dhrystone(1.1) time for 1233977344 passes = 30.9 > This machine benchmarks at 39968549 dhrystones/second > 22748 DMIPS > Dhrystone(1.1) time for 1233977344 passes = 31.0 > This machine benchmarks at 39817431 dhrystones/second > 22662 DMIPS > > Total dhrystone run time: 31.995136 seconds. > > Bottomline: removing the lower-frequency OPPs led to a 3.8% drop in > performance in this setup. This is probably far from a reliable > estimate, but I guess it indeed indicates that having lower-frequency > states might be beneficial in some load scenarios. Measuring a difference of about 4% may be attributed to some unknown inaccuracy or test deviation, but again, a performance improvement of about 4% that comes free of charge is nothing to be sneezed at, IMHO. > Note though that several seconds after hitting the throttling > threshold cores 6-7 were oscillating between 1.608GHz and 1.8GHz in > both runs, which implies that the whole difference in performance was > due to different speed of initial throttling (i.e. it might be a > peculiarity of the step-wise thermal governor operation when it has to > go through more cooling states to reach the "steady-state" one). Given > that both 1.608GHz and 1.8GHz have no lower-frequency same-voltage > siblings in either of the OPP tables, it implies that under prolonged > constant load there should be no performance difference at all. ... all that with one possible cooling setup, and with one synthetic test. We simply can't know in advance how would a different cooling setup on the same or on a different board behave, if you agree.