From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Ilias Stamatis <ilstam@amazon.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, nadav.amit@gmail.com,
huang.ying.caritas@gmail.com, andriy.shevchenko@linux.intel.com,
bhe@redhat.com, nh-open-source@amazon.com
Subject: Re: [PATCH] Reinstate "resource: avoid unnecessary lookups in find_next_iomem_res()"
Date: Tue, 25 Nov 2025 09:09:02 +0100 [thread overview]
Message-ID: <9fdc1d1f-ce00-47ff-bdf5-66e8a511be25@kernel.org> (raw)
In-Reply-To: <20251124165349.3377826-1-ilstam@amazon.com>
On 11/24/25 17:53, Ilias Stamatis wrote:
> Commit 97523a4edb7b ("kernel/resource: remove first_lvl / siblings_only
> logic") removed an optimization introduced by commit 756398750e11
> ("resource: avoid unnecessary lookups in find_next_iomem_res()"). That
> was not called out in the message of the first commit explicitly so it's
> not entirely clear whether removing the optimization happened
> inadvertently or not.
Remembering the history, we have some things where the top might not
fully describe what the lower levels do.
An example is for example found here:
Author: Dan Williams <dan.j.williams@intel.com>
Date: Thu Feb 16 00:36:02 2023 -0800
dax/kmem: Fix leak of memory-hotplug resources
While experimenting with CXL region removal the following corruption of
/proc/iomem appeared.
Before:
f010000000-f04fffffff : CXL Window 0
f010000000-f02fffffff : region4
f010000000-f02fffffff : dax4.0
f010000000-f02fffffff : System RAM (kmem)
The CXL Windows will certainly not match System RAM, as one example.
How would your change affect such cases?
--
Cheers
David
next prev parent reply other threads:[~2025-11-25 8:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 16:53 [PATCH] Reinstate "resource: avoid unnecessary lookups in find_next_iomem_res()" Ilias Stamatis
2025-11-24 16:58 ` Andrew Morton
2025-11-24 17:05 ` Andy Shevchenko
2025-11-24 18:01 ` Stamatis, Ilias
2025-11-24 18:55 ` andriy.shevchenko
2025-11-24 19:35 ` Stamatis, Ilias
2025-11-24 19:52 ` andriy.shevchenko
2025-11-24 23:30 ` Stamatis, Ilias
2025-11-25 6:50 ` andriy.shevchenko
2025-11-25 9:56 ` Stamatis, Ilias
2025-11-25 10:23 ` andriy.shevchenko
2025-11-25 14:23 ` Stamatis, Ilias
2025-11-25 18:30 ` andriy.shevchenko
2025-11-25 8:09 ` David Hildenbrand (Red Hat) [this message]
2025-11-25 8:18 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fdc1d1f-ce00-47ff-bdf5-66e8a511be25@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhe@redhat.com \
--cc=huang.ying.caritas@gmail.com \
--cc=ilstam@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nadav.amit@gmail.com \
--cc=nh-open-source@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.