From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] examples/vhost_crypto: fix parsing Date: Tue, 10 Apr 2018 11:40:32 +0200 Message-ID: <9fdd3dea-8646-91c3-da29-46ba16aae136@redhat.com> References: <20180409163832.85611-1-roy.fan.zhang@intel.com> <20180409175740.86858-1-roy.fan.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: ferruh.yigit@intel.com To: Fan Zhang , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 79E2D1B84C for ; Tue, 10 Apr 2018 11:40:37 +0200 (CEST) In-Reply-To: <20180409175740.86858-1-roy.fan.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/09/2018 07:57 PM, Fan Zhang wrote: > Fixes: 2ce5bd8c442d ("examples/vhost_crypto: add vhost crypto sample application") > > This patch fixes the parsing of cryptodev id in the cmdline. > > Signed-off-by: Fan Zhang > --- > examples/vhost_crypto/main.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c > index bc867240d..860200e29 100644 > --- a/examples/vhost_crypto/main.c > +++ b/examples/vhost_crypto/main.c > @@ -95,11 +95,6 @@ parse_cryptodev_id(const char *q_arg) > > /* parse decimal string */ > pm = strtoul(q_arg, &end, 10); > - if ((pm == '\0') || (end == NULL) || (*end != '\0')) { > - RTE_LOG(ERR, USER1, "Invalid Cryptodev ID %s\n", q_arg); > - return -1; > - } > - > if (pm > rte_cryptodev_count()) { > RTE_LOG(ERR, USER1, "Invalid Cryptodev ID %s\n", q_arg); > return -1; > Acked-by: Maxime Coquelin I'll squash it with faulty commit if not yet merged by Ferruh. Thanks, Maxime