Re: [PATCH v2 2/3] btrfs-progs: dir-item: Don't do extra filetype validaction check for btrfs_match_dir_item_name

[Su Yue <suy.fnst@cn.fujitsu.com>]

On 01/19/2018 03:25 PM, Qu Wenruo wrote:
> btrfs_match_dir_item_name() will check if its filetype is valid before
> doing search, this makes btrfs-progs unable to locate and remove invalid
> dir_index for btrfs_unlink().
> 
> This function only affects btrfs_link() and btrfs_unlink() in upper
> layer, and normal check can find invalid filetype by itself.
> 
Lowmem mode can't handles wrong filetype well now.
I'm working on it. And this change is okay for me.

Reviewed-by: Su Yue <suy.fnst@cn.fujitsu.com>

> So remove the filetype check is completely safe in this case, and will
> enhance btrfs_unlink() to remove invalid dir_index/dir_item for repair.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>   dir-item.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/dir-item.c b/dir-item.c
> index 462546c0eaf4..e0a0ab4d7a5d 100644
> --- a/dir-item.c
> +++ b/dir-item.c
> @@ -294,12 +294,6 @@ static int verify_dir_item(struct btrfs_root *root,
>   	u16 namelen = BTRFS_NAME_LEN;
>   	u8 type = btrfs_dir_type(leaf, dir_item);
>   
> -	if (type >= BTRFS_FT_MAX) {
> -		fprintf(stderr, "invalid dir item type: %d\n",
> -		       (int)type);
> -		return 1;
> -	}
> -
>   	if (type == BTRFS_FT_XATTR)
>   		namelen = XATTR_NAME_MAX;
>   
>