All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Heiner Kallweit" <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Dimitri Fedrau <dima.fedrau@gmail.com>,
	netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [net-next] net: phy: marvell-88q2xxx: Enable temperature sensor for mv88q211x
Date: Fri, 21 Mar 2025 21:37:16 +0100	[thread overview]
Message-ID: <9fe63634-9961-451a-b98d-0a9df1eef8b4@redhat.com> (raw)
In-Reply-To: <20250316120214.GA360499@ragnatech.se>

Hi,

On 3/16/25 1:02 PM, Niklas Söderlund wrote:
> On 2025-03-16 12:47:55 +0100, Heiner Kallweit wrote:
>> On 16.03.2025 12:20, Niklas Söderlund wrote:
>>> The temperature sensor enabled for mv88q222x devices also functions for
>>> mv88q211x based devices. Unify the two devices probe functions to enable
>>> the sensors for all devices supported by this driver.
>>>
>>> The same oddity as for mv88q222x devices exists, the PHY must be up for
>>> a correct temperature reading to be reported.
>>>
>> In this case, wouldn't it make sense to extend mv88q2xxx_hwmon_is_visible()
>> and hide the temp_input attribute if PHY is down? 
>> Whatever down here means in detail: Link down? In power-down mode?
> 
> These are good suggestions, this issue is being worked on [1]. I just 
> wanted to highlight that this entablement behaves the same as the 
> current models that support the temperature sensor and log how this was 
> tested on mv88q211x.
> 
> 1.  https://lore.kernel.org/all/20250220-marvell-88q2xxx-hwmon-enable-at-probe-v2-0-78b2838a62da@gmail.com/

My take is that you should at least clarify in the commit message the
state required for a correct reading - e.g. link up vs power-up.

Thanks,

Paolo


  reply	other threads:[~2025-03-21 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-16 11:20 [net-next] net: phy: marvell-88q2xxx: Enable temperature sensor for mv88q211x Niklas Söderlund
2025-03-16 11:47 ` Heiner Kallweit
2025-03-16 12:02   ` Niklas Söderlund
2025-03-21 20:37     ` Paolo Abeni [this message]
2025-03-16 15:23 ` Dimitri Fedrau
2025-03-17  0:32   ` Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fe63634-9961-451a-b98d-0a9df1eef8b4@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dima.fedrau@gmail.com \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.