From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B536FA1 for ; Mon, 3 Apr 2023 16:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1680539050; x=1712075050; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+Jb7mW8GgKs3X7qIWTnQ9maer3rwE4789mQjXaeVBpE=; b=lJ3kmhoEy3JkM7jinXdXjuM9+79h3FN3an+/sN2xwOIv6Dxa0ng2XZFT PtKHOAIDWeBTLN8AGLIw032iPiBKnkmvUeFgiB5EuFIvx4WpRB+xqhmEE MnW3HM1/jrjHOv6y0BiTnUJbDDAwlmHl7sJBQuU3uWpByQ0eWV2pCEcV3 h1fVJK2diDNFptwTnfBI8I2YSLwDN2RS+QQIJ3OCZNd34YptDKmDdddur /E++X8CBaxaeeABZaj5u1W1Cc8PJKn23H7TvholBn+tChj5/Ptj/2blcu N5QLuvddGdmagRirl9UrjMqzQM0AygtzdlcaaSLaWarwO0vYF6qyhNlQf w==; X-IronPort-AV: E=Sophos;i="5.98,315,1673938800"; d="scan'208";a="208610422" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Apr 2023 09:23:59 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 3 Apr 2023 09:23:49 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 3 Apr 2023 09:23:46 -0700 Message-ID: <9ffe89c5-260a-a95e-0e7b-b5eca0b8c050@microchip.com> Date: Mon, 3 Apr 2023 18:23:39 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 07/24] staging: media: atmel-sama7g5-isc: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Eugen Hristev" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Alexandre Belloni , Claudiu Beznea CC: , , , References: <20230403154014.2564054-1-u.kleine-koenig@pengutronix.de> <20230403154014.2564054-8-u.kleine-koenig@pengutronix.de> From: Nicolas Ferre Organization: microchip In-Reply-To: <20230403154014.2564054-8-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 03/04/2023 at 17:39, Uwe Kleine-König wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Acked-by: Nicolas Ferre > --- > drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c > index 01ababdfcbd9..315bfc4ac4ff 100644 > --- a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c > +++ b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c > @@ -549,7 +549,7 @@ static int microchip_xisc_probe(struct platform_device *pdev) > return ret; > } > > -static int microchip_xisc_remove(struct platform_device *pdev) > +static void microchip_xisc_remove(struct platform_device *pdev) > { > struct isc_device *isc = platform_get_drvdata(pdev); > > @@ -562,8 +562,6 @@ static int microchip_xisc_remove(struct platform_device *pdev) > clk_disable_unprepare(isc->hclock); > > atmel_isc_clk_cleanup(isc); > - > - return 0; > } > > static int __maybe_unused xisc_runtime_suspend(struct device *dev) > @@ -601,7 +599,7 @@ MODULE_DEVICE_TABLE(of, microchip_xisc_of_match); > > static struct platform_driver microchip_xisc_driver = { > .probe = microchip_xisc_probe, > - .remove = microchip_xisc_remove, > + .remove_new = microchip_xisc_remove, > .driver = { > .name = "microchip-sama7g5-xisc", > .pm = µchip_xisc_dev_pm_ops, > -- > 2.39.2 > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 053F8C76188 for ; Mon, 3 Apr 2023 16:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3iMCitHh+0aT5vQT16h4u0mwXvFGFe4ahJlavAYg7TM=; b=x2VN4ksDMDJJJ+ cjUdOZar3ztAmQhXvXLtTU9nDhBd/68FPzPXYpaZ2Y6d8nEcaVDjdypTp2mrPbf9gSV+RHYQ9rANN m8uIKoujfj9wQpyT6VZgtJWTyHSuEzoWmdWXNROyZhdV/VViF6rXCaRfO/3B5FTr25tBFlNxBpaRs BvrSucyPZmmtpF21H8GYa9OUMQFjz3qe8coh862iZuoP72SX8GcKTC6EDsli4E0P5xrqIu1PtVYwz le/DXSdhtE3NY9BX8Iy9DMsmJvB8a43smkxrpR7T44msfO692IMMwsW1mny7WXqfUYVbwKp9OiFs0 rPfjnzrJLwFwSkXtlmaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjMyc-00Fx3l-39; Mon, 03 Apr 2023 16:24:15 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjMyY-00Fx1K-0N for linux-arm-kernel@lists.infradead.org; Mon, 03 Apr 2023 16:24:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1680539049; x=1712075049; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+Jb7mW8GgKs3X7qIWTnQ9maer3rwE4789mQjXaeVBpE=; b=wcXXaRrhY3HO1GjbbLRDpj2efjQEscUXlQxaVbrhEGT4lbFar6GECVrb +7giOR5GAFT3vffzxhN2RhcrCzvUxI8scGxrd0gyumiu2BQXNlTi86GHS H2WoITb8aBZk+W07zNWLI8d4/fIVEEBYvEyCpSQXMTco40siZg+qr82RM EDizgHwWrbD760Av0m6Ky+9ieb2cvVmICfqAkaIFi/3lrBgqNcdR6pW0S tIf1EV0u6xf7HUiaui3/zBDm7XKndP9e054yMJx+6xbVlp9ZBZfFRFyk/ CTxc1qNzLdylwJqgE7/N2gkxjnX7wQeZ3ODvRxpHj3+uRrNxQeaX1RZ80 w==; X-IronPort-AV: E=Sophos;i="5.98,315,1673938800"; d="scan'208";a="208610422" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Apr 2023 09:23:59 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 3 Apr 2023 09:23:49 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 3 Apr 2023 09:23:46 -0700 Message-ID: <9ffe89c5-260a-a95e-0e7b-b5eca0b8c050@microchip.com> Date: Mon, 3 Apr 2023 18:23:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 07/24] staging: media: atmel-sama7g5-isc: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Eugen Hristev" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Alexandre Belloni , Claudiu Beznea CC: , , , References: <20230403154014.2564054-1-u.kleine-koenig@pengutronix.de> <20230403154014.2564054-8-u.kleine-koenig@pengutronix.de> From: Nicolas Ferre Organization: microchip In-Reply-To: <20230403154014.2564054-8-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230403_092410_213105_BFDF7708 X-CRM114-Status: GOOD ( 23.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDMvMDQvMjAyMyBhdCAxNzozOSwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4gRVhURVJO QUwgRU1BSUw6IERvIG5vdCBjbGljayBsaW5rcyBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5 b3Uga25vdyB0aGUgY29udGVudCBpcyBzYWZlCj4gCj4gVGhlIC5yZW1vdmUoKSBjYWxsYmFjayBm b3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBpbnQgd2hpY2ggbWFrZXMKPiBtYW55IGRy aXZlciBhdXRob3JzIHdyb25nbHkgYXNzdW1lIGl0J3MgcG9zc2libGUgdG8gZG8gZXJyb3IgaGFu ZGxpbmcgYnkKPiByZXR1cm5pbmcgYW4gZXJyb3IgY29kZS4gSG93ZXZlciB0aGUgdmFsdWUgcmV0 dXJuZWQgaXMgKG1vc3RseSkgaWdub3JlZAo+IGFuZCB0aGlzIHR5cGljYWxseSByZXN1bHRzIGlu IHJlc291cmNlIGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUgaXMgYQo+IHF1ZXN0IHRvIG1h a2UgdGhlIHJlbW92ZSBjYWxsYmFjayByZXR1cm4gdm9pZC4gSW4gdGhlIGZpcnN0IHN0ZXAgb2Yg dGhpcwo+IHF1ZXN0IGFsbCBkcml2ZXJzIGFyZSBjb252ZXJ0ZWQgdG8gLnJlbW92ZV9uZXcoKSB3 aGljaCBhbHJlYWR5IHJldHVybnMKPiB2b2lkLgo+IAo+IFRyaXZpYWxseSBjb252ZXJ0IHRoaXMg ZHJpdmVyIGZyb20gYWx3YXlzIHJldHVybmluZyB6ZXJvIGluIHRoZSByZW1vdmUKPiBjYWxsYmFj ayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBVd2Ug S2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgoKQWNrZWQtYnk6 IE5pY29sYXMgRmVycmUgPG5pY29sYXMuZmVycmVAbWljcm9jaGlwLmNvbT4KCj4gLS0tCj4gICBk cml2ZXJzL3N0YWdpbmcvbWVkaWEvZGVwcmVjYXRlZC9hdG1lbC9hdG1lbC1zYW1hN2c1LWlzYy5j IHwgNiArKy0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9kZXByZWNhdGVk L2F0bWVsL2F0bWVsLXNhbWE3ZzUtaXNjLmMgYi9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvZGVwcmVj YXRlZC9hdG1lbC9hdG1lbC1zYW1hN2c1LWlzYy5jCj4gaW5kZXggMDFhYmFiZGZjYmQ5Li4zMTVi ZmM0YWM0ZmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9zdGFnaW5nL21lZGlhL2RlcHJlY2F0ZWQv YXRtZWwvYXRtZWwtc2FtYTdnNS1pc2MuYwo+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9k ZXByZWNhdGVkL2F0bWVsL2F0bWVsLXNhbWE3ZzUtaXNjLmMKPiBAQCAtNTQ5LDcgKzU0OSw3IEBA IHN0YXRpYyBpbnQgbWljcm9jaGlwX3hpc2NfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikKPiAgICAgICAgICByZXR1cm4gcmV0Owo+ICAgfQo+IAo+IC1zdGF0aWMgaW50IG1pY3Jv Y2hpcF94aXNjX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICtzdGF0aWMg dm9pZCBtaWNyb2NoaXBfeGlzY19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK PiAgIHsKPiAgICAgICAgICBzdHJ1Y3QgaXNjX2RldmljZSAqaXNjID0gcGxhdGZvcm1fZ2V0X2Ry dmRhdGEocGRldik7Cj4gCj4gQEAgLTU2Miw4ICs1NjIsNiBAQCBzdGF0aWMgaW50IG1pY3JvY2hp cF94aXNjX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAgICAgICAgIGNs a19kaXNhYmxlX3VucHJlcGFyZShpc2MtPmhjbG9jayk7Cj4gCj4gICAgICAgICAgYXRtZWxfaXNj X2Nsa19jbGVhbnVwKGlzYyk7Cj4gLQo+IC0gICAgICAgcmV0dXJuIDA7Cj4gICB9Cj4gCj4gICBz dGF0aWMgaW50IF9fbWF5YmVfdW51c2VkIHhpc2NfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkZXZp Y2UgKmRldikKPiBAQCAtNjAxLDcgKzU5OSw3IEBAIE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIG1p Y3JvY2hpcF94aXNjX29mX21hdGNoKTsKPiAKPiAgIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJp dmVyIG1pY3JvY2hpcF94aXNjX2RyaXZlciA9IHsKPiAgICAgICAgICAucHJvYmUgID0gbWljcm9j aGlwX3hpc2NfcHJvYmUsCj4gLSAgICAgICAucmVtb3ZlID0gbWljcm9jaGlwX3hpc2NfcmVtb3Zl LAo+ICsgICAgICAgLnJlbW92ZV9uZXcgPSBtaWNyb2NoaXBfeGlzY19yZW1vdmUsCj4gICAgICAg ICAgLmRyaXZlciA9IHsKPiAgICAgICAgICAgICAgICAgIC5uYW1lICAgICAgICAgICA9ICJtaWNy b2NoaXAtc2FtYTdnNS14aXNjIiwKPiAgICAgICAgICAgICAgICAgIC5wbSAgICAgICAgICAgICA9 ICZtaWNyb2NoaXBfeGlzY19kZXZfcG1fb3BzLAo+IC0tCj4gMi4zOS4yCj4gCgotLSAKTmljb2xh cyBGZXJyZQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK