From: Thorsten Blum <thorsten.blum@linux.dev>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Suren Baghdasaryan <surenb@google.com>,
Wei Yang <richard.weiyang@gmail.com>,
David Hildenbrand <david@redhat.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fork: Remove unnecessary size argument when calling strscpy()
Date: Tue, 18 Mar 2025 23:50:03 +0100 [thread overview]
Message-ID: <A0877360-6B98-48F3-9A6C-398AAD12F3B5@linux.dev> (raw)
In-Reply-To: <05250cea-4738-4bfa-a669-a81a64d3e82e@lucifer.local>
On 11. Mar 2025, at 12:13, Lorenzo Stoakes wrote:
> On Tue, Mar 11, 2025 at 12:05:39PM +0100, Thorsten Blum wrote:
>> The size parameter is optional and strscpy() automatically determines
>> the length of the destination buffer using sizeof() if the argument is
>> omitted. This makes the explicit sizeof() unnecessary. Remove it to
>> simplify the code.
>>
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>
> Hm not sure about this one, it's not really simplifying anything all too
> much and seems like somewhat useless churn?
>
> It's pretty clear what's going on here already.
Yes, but explicitly specifying the default value for an optional
parameter is redundant, and omitting it simplifies the code.
Thanks,
Thorsten
prev parent reply other threads:[~2025-03-18 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 11:05 [PATCH] fork: Remove unnecessary size argument when calling strscpy() Thorsten Blum
2025-03-11 11:13 ` Lorenzo Stoakes
2025-03-18 22:50 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A0877360-6B98-48F3-9A6C-398AAD12F3B5@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=surenb@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.