All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: yangge1116@126.com
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, 21cnbao@gmail.com,
	david@redhat.com, baolin.wang@linux.alibaba.com,
	osalvador@suse.de, liuzixing@hygon.cn
Subject: Re: [PATCH] mm/hugetlb: remove redundant folio_test_hugetlb
Date: Fri, 23 May 2025 16:30:15 +0800	[thread overview]
Message-ID: <A1F5AF70-6C43-49A2-943E-CCCE62BA6A8E@linux.dev> (raw)
In-Reply-To: <1747987559-23082-1-git-send-email-yangge1116@126.com>



> On May 23, 2025, at 16:05, yangge1116@126.com wrote:
> 
> From: Ge Yang <yangge1116@126.com>
> 
> In the isolate_or_dissolve_huge_folio() function, the folio_test_hugetlb()
> function is called to determine whether a folio is a hugetlb folio.
> However, in the subsequent alloc_and_dissolve_hugetlb_folio() function,
> the folio_test_hugetlb() function is called again to make the same
> determination about whether the folio is a hugetlb folio. It appears that
> the folio_test_hugetlb() check in the isolate_or_dissolve_huge_folio()
> function can be removed. Additionally, a similar issue exists in the
> replace_free_hugepage_folios() function, and it should be addressed as
> well.
> 
> Suggested-by: Oscar Salvador <osalvador@suse.de>
> Signed-off-by: Ge Yang <yangge1116@126.com <mailto:yangge1116@126.com>>

Reviewed-by: Muchun Song <muchun.song@linux.dev>

Thanks.



  parent reply	other threads:[~2025-05-23  8:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23  8:05 [PATCH] mm/hugetlb: remove redundant folio_test_hugetlb yangge1116
2025-05-23  8:23 ` Oscar Salvador
2025-05-23  8:30 ` Muchun Song [this message]
2025-05-26 12:20 ` David Hildenbrand
2025-05-26 12:23   ` David Hildenbrand
2025-05-26 13:05     ` Oscar Salvador
2025-05-26 13:06       ` David Hildenbrand
2025-05-26 13:09         ` Oscar Salvador
2025-05-26 13:10         ` Ge Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A1F5AF70-6C43-49A2-943E-CCCE62BA6A8E@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuzixing@hygon.cn \
    --cc=osalvador@suse.de \
    --cc=yangge1116@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.