All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Keith Moore <keithmo@exmsft.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.7-mm1 PCNet Problems under VMWare 4.5.2
Date: Wed, 23 Jun 2004 16:26:52 +0200	[thread overview]
Message-ID: <A212D9E4842@vcnet.vc.cvut.cz> (raw)

On 23 Jun 04 at 11:23, Keith Moore wrote:
> -    /* Clear any other interrupt, and set interrupt enable. */
> -    lp->a.write_csr (ioaddr, 0, 0x7940);
> +    /* Set interrupt enable. */
> +    lp->a.write_csr (ioaddr, 0, 0x0040);
> 
> Reverting this one section of the patch makes eth0 happy again.
> 
> I poked around with the values written to the csr register, and it 
> appears the virtual PCNet-II adapter needs bit 0x0100 (initialzation 
> done) set. So, writing 0x0140 instead of 0x0040 seems to work well.
> 
> I have no idea how accurate VMWare's emulation of this adapter is, or if 
> this change may cause problems with other (physical) adapters.

I believe that it is not emulation bug. What happens is that you do not
confirm INIT DONE irq, causing endless stream of interrupts from card to
the CPU. This happens because CSR3 default value is 0 (enable all 
interrupts), and driver does not modify it in any way (f.e. for
preventing INIT from causing interrupt). So when init is done, IDON
irq fires. In old driver it was acked by 0x7940 (or by 0x0140 in your
modified driver), but in new driver it is not acked in any way,
triggering this very same IRQ over and over.

pcnet32_interrupt should loop while csr0 contains some pending
interrupts (current mask 0x8600 should be changed to 0xDE00 to be 100%
sure that all interrupts we handle in loop are catched), and then
clear all other interrupts sources (0x2140) out of the loop.

Other possibility is masking these unused sources in CSR3...

But I believe that driver from -mm1 will hang even on real Am79C970A
hardware.
                                            Best regards,
                                                Petr Vandrovec
                                                


             reply	other threads:[~2004-06-23 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-23 14:26 Petr Vandrovec [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-06-23  9:23 2.6.7-mm1 PCNet Problems under VMWare 4.5.2 Keith Moore
2004-06-23 10:08 ` Esteve Espuña Sargatal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A212D9E4842@vcnet.vc.cvut.cz \
    --to=vandrove@vc.cvut.cz \
    --cc=keithmo@exmsft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.