From: Toomas Soome <tsoome@me.com>
To: smatch@vger.kernel.org
Subject: smatch, __builtin_unreachable() and uninitialized var...
Date: Mon, 17 Nov 2025 11:50:42 +0200 [thread overview]
Message-ID: <A2726870-BF00-4BCE-A3CD-512B490AA644@me.com> (raw)
hi!
While using smatch with OpenZFS code, we have stepped on this issue:
/home/runner/work/zfs/zfs/zfs/module/icp/algs/aes/aes_modes.c:90 aes_encrypt_contiguous_blocks() error: uninitialized symbol 'rv'.
The function is using conditional call to function, which return value is stored to rv and the “impossible” else leg is marked with __builtin_unreachable() as seen there:
https://github.com/openzfs/zfs/blob/master/module/icp/algs/aes/aes_modes.c#L77
it would be nice if smatch could use __builtin_unreachable() there to avoid this error…
thanks,
toomas
next reply other threads:[~2025-11-17 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 9:50 Toomas Soome [this message]
2025-11-18 11:14 ` smatch, __builtin_unreachable() and uninitialized var Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2726870-BF00-4BCE-A3CD-512B490AA644@me.com \
--to=tsoome@me.com \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.