From: Muchun Song <muchun.song@linux.dev>
To: Zi Yan <ziy@nvidia.com>
Cc: Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mips@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
"Mike Rapoport (IBM)" <rppt@kernel.org>
Subject: Re: [PATCH 1/3] mm: use nth_page() in place of direct struct page manipulation.
Date: Thu, 31 Aug 2023 15:14:15 +0800 [thread overview]
Message-ID: <A40C2788-050A-4A1D-8804-5B718B72E879@linux.dev> (raw)
In-Reply-To: <20230830182753.55367-2-zi.yan@sent.com>
> On Aug 31, 2023, at 02:27, Zi Yan <zi.yan@sent.com> wrote:
>
> From: Zi Yan <ziy@nvidia.com>
>
> When dealing with hugetlb pages, manipulating struct page pointers
> directly can get to wrong struct page, since struct page is not guaranteed
> to be contiguous on SPARSEMEM without VMEMMAP. Use nth_page() to handle
> it properly.
>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Maybe 3 separate patches would be better for backporting purpose.
next prev parent reply other threads:[~2023-08-31 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 18:27 [PATCH 0/3] Use nth_page() in place of direct struct page manipulation Zi Yan
2023-08-30 18:27 ` [PATCH 1/3] mm: use " Zi Yan
2023-08-31 7:14 ` Muchun Song [this message]
2023-08-31 15:37 ` Zi Yan
2023-08-30 18:27 ` [PATCH 2/3] fs: " Zi Yan
2023-08-31 7:17 ` [PATCH 2/3] " Muchun Song
2023-08-31 15:37 ` Zi Yan
2023-08-30 18:27 ` [PATCH 3/3] mips: " Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A40C2788-050A-4A1D-8804-5B718B72E879@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=rppt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.