From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2DCO-0001jR-7E
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 18:08:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2DCM-0001jA-UN
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 18:08:03 -0500
Received: from [199.232.76.173] (port=57999 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2DCM-0001j5-MA
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 18:08:02 -0500
Received: from mail.gmx.net ([213.165.64.20]:49439)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1L2DCM-0001gm-0y
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 18:08:02 -0500
Message-ID: <A534A51B2B224583BCFDE65869D1D29A@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <20081116110141.GM20617@redhat.com>
	<55BF96155E3B42A2A577975171920809@FSCPC>
	<20081116180129.GE6059@redhat.com>
In-Reply-To: <20081116180129.GE6059@redhat.com>
Subject: Re: [Bochs-developers] [Qemu-devel] [PATCH v4 1/5] Add S3
	statetoDSDT. Handle resume event in the BIOS.
Date: Tue, 18 Nov 2008 00:07:29 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org

Gleb Natapov wrote:
> On Sun, Nov 16, 2008 at 06:54:38PM +0100, Sebastian Herbszt wrote:
>> Gleb Natapov wrote:
>>> On Sun, Nov 16, 2008 at 12:50:55PM +0200, Blue Swirl wrote:
>>>> On 11/16/08, Gleb Natapov <gleb@redhat.com> wrote:
>>>> >  +void s3_resume_panic()
>>>>
>>>> How about rather:
>>>> void s3_resume_panic(void)
>>>>
>>>> >  +int
>>>> >  +s3_resume()
>>>>
>>>> s3_resume(void)?
>>>
>>> Have you tried it? :)
>>>
>>> Hint: bcc doesn't support ANSI-C.
>>
>> It accepts some ansi-c with "-ansi". Man page says
>> "-ansi  Pass  the  C  source  through unprotoize after preprocessing and
>> before code generation. This will allow some ansi C to be compiled but
>> it is definitly NOT a true ansi-C compiler."
>>
> But BOCHS doesn't use this flag. Do you what to add it and fix all
> function prototypes? Seems like to much work for a little gain.

No, i currently don't plan to change this.

- Sebastian