From: Akio Takebe <takebe_akio@jp.fujitsu.com>
To: kexec-ml <kexec@lists.infradead.org>,
Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Subject: [Patch] fix error case of xen
Date: Tue, 01 Apr 2008 02:24:32 +0900 [thread overview]
Message-ID: <A7C89354154DF3takebe_akio@jp.fujitsu.com> (raw)
Hi,
Curret kdump-xen with makdumpfile always return 0.
So if we fail to kdump, we will get $?=0.
This patch improve it.
Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>
--- makedumpfile/makedumpfile.c 2008-03-28 11:32:51.000000000 +0900
+++ makedumpfile.mod/makedumpfile.c 2008-04-01 02:14:12.000000000 +0900
@@ -993,6 +993,8 @@ get_symbol_addr(char *symname)
if (!strcmp(sym_name, symname)) {
symbol = sym.st_value;
break;
+ } else if (i >= (shdr.sh_size/shdr.sh_entsize)-1) {
+ DEBUG_MSG("Can't get symbol of %s.\n", symname);
}
}
out:
@@ -6146,7 +6148,8 @@ main(int argc, char *argv[])
goto out;
}
info->dump_level |= DL_EXCLUDE_XEN;
- return handle_xen();
+ if (!handle_xen())
+ goto out;
} else if (info->flag_rearrange) {
if (!open_files_for_rearranging_dumpdata())
Best Regards,
Akio Takebe
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2008-03-31 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 17:24 Akio Takebe [this message]
2008-04-01 6:04 ` [Patch] fix error case of xen Ken'ichi Ohmichi
2008-04-01 7:55 ` Ken'ichi Ohmichi
2008-04-01 23:54 ` Akio Takebe
2008-04-02 1:28 ` Akio Takebe
2008-04-02 4:47 ` Ken'ichi Ohmichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A7C89354154DF3takebe_akio@jp.fujitsu.com \
--to=takebe_akio@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=oomichi@mxs.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.