All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: Mehmet Fide <mehmet.fide@gmail.com>, Ping-Ke Shih <pkshih@realtek.com>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	Kalle Valo <kvalo@kernel.org>,
	Stanislaw Gruszka <sgruszka@redhat.com>,
	Brian Norris <briannorris@chromium.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v2] wifi: rtw88: program the beacon interval
Date: Tue, 17 Nov 2026 13:30:15 +0100	[thread overview]
Message-ID: <AF1A064D-D778-4269-BE69-060FC29532F4@linux.dev> (raw)
In-Reply-To: <20261117101419.1687892-1-mehmet.fide@gmail.com>

On November 17, 2026 11:14:19 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:
>From: Mehmet Fide <mehmet.fide@screeningeagle.com>
>
>The driver never writes the beacon interval register, so the hardware
>keeps its default of 100 TU. An AP or IBSS started with another
>interval says that interval in its beacons and sends them 100 TU apart.
>
>With beacon_int=200 in hostapd the beacons of an RTL8822CE, RTL8822CU,
>RTL8822BU and RTL8821CU are 102.4 ms apart on the air. The same holds
>for an IBSS joined with a beacon interval of 200 on an RTL8822CE and
>RTL8822BU.
>
>Write the interval when mac80211 sets it for an AP or IBSS interface.
>Both beacon from port 0: rtw_core_port_switch() moves an AP there, and
>an IBSS interface is never combined with another one.
>
>Reported-by: Luka Gejak <luka.gejak@linux.dev>
>Closes: https://lore.kernel.org/linux-wireless/1D396970-35B7-4B0B-82E9-24B523AD69C2@linux.dev/
>Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
>Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
>---
>
>Notes:
>    v2:
>    - write the interval for an AP or IBSS interface only (Ping-Ke)
>    - Luka's Reviewed-by not carried, the condition changed
>    - rebased on rtw-next fb51e39dfaea
>    
>    Tested on rtw-next on an RTL8822CE, RTL8822CU, RTL8822BU and RTL8821CU
>    as AP with hostapd, the beacons sniffed from a second machine: with
>    beacon_int 50, 100 and 200 they are 51.2, 102.4 and 204.8 ms apart on
>    the air. As IBSS on the RTL8822CE and RTL8822BU, joined with a beacon
>    interval of 50 and 200, the TSF of their beacons shows them 50 and 200
>    TU apart. AP, association, power save, firmware crash and scan tests on
>    the RTL8822BU and RTL8821CU on both bands gave no new kernel report.
>    
>    v1: https://lore.kernel.org/r/20261116072022.1142783-1-mehmet.fide@gmail.com/
>
> drivers/net/wireless/realtek/rtw88/mac80211.c | 5 +++++
> drivers/net/wireless/realtek/rtw88/reg.h      | 1 +
> 2 files changed, 6 insertions(+)
>
>diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
>index 5e40cf06a9e3..26bc4a9913be 100644
>--- a/drivers/net/wireless/realtek/rtw88/mac80211.c
>+++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
>@@ -432,6 +432,11 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
> 	if (changed & BSS_CHANGED_BEACON_INT) {
> 		if (ieee80211_vif_type_p2p(vif) == NL80211_IFTYPE_STATION)
> 			coex_stat->wl_beacon_interval = conf->beacon_int;
>+		else if ((vif->type == NL80211_IFTYPE_AP ||
>+			  vif->type == NL80211_IFTYPE_ADHOC) &&
>+			 rtwvif->port == RTW_PORT_0)
>+			rtw_write16(rtwdev, REG_MBSSID_BCN_SPACE,
>+				    conf->beacon_int);
> 	}
> 
> 	if (changed & BSS_CHANGED_BEACON) {

[ ... ]

As far as I can see this is the same as v1 just expressed explicitly.
Either way I am fine with it.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

  reply	other threads:[~2026-11-17 12:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:14 [PATCH rtw-next v2] wifi: rtw88: program the beacon interval Mehmet Fide
2026-11-17 12:30 ` Luka Gejak [this message]
2026-11-18  2:05 ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AF1A064D-D778-4269-BE69-060FC29532F4@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=briannorris@chromium.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mehmet.fide@gmail.com \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=sgruszka@redhat.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.