All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marko, Peter" <Peter.Marko@siemens.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core][PATCH] systemd: make predictable name mac policy opt-out
Date: Tue, 9 Apr 2024 09:57:08 +0000	[thread overview]
Message-ID: <AS1PR10MB569732EB0A58FF2C515A9B25FD072@AS1PR10MB5697.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CANNYZj-HosUT6unGOohfRA22x9MWbUgYDn5N=mWjELVkTjBQsg@mail.gmail.com>

-----Original Message-----
From: Alexander Kanavin <alex.kanavin@gmail.com> 
Sent: Tuesday, April 9, 2024 11:16
To: Marko, Peter (ADV D EU SK BFS1) <Peter.Marko@siemens.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] systemd: make predictable name mac policy opt-out

> On Mon, 8 Apr 2024 at 09:06, Peter Marko via lists.openembedded.org <peter.marko=siemens.com@lists.openembedded.org> wrote:
> > -           file://0001-NamePolicy.patch \
> > +           ${@bb.utils.contains('PACKAGECONFIG', 
> > + 'predictable-if-mac', 'file://0001-NamePolicy.patch', '', d)} \
>
> Conditional patches are terrible for maintainability. Please make it a proper meson option, and submit upstream.
>
> Alex

This patch has status upstream inappropriate.
Pushing something like that to upstream doesn't sound like a good plan.

What about reverting the inappropriate patch completely instead?

Peter

  reply	other threads:[~2024-04-09  9:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  7:04 [OE-core][PATCH] systemd: make predictable name mac policy opt-out Peter Marko
2024-04-09  9:16 ` Alexander Kanavin
2024-04-09  9:57   ` Marko, Peter [this message]
2024-04-09 10:02     ` Alexander Kanavin
2024-04-10 15:59 ` Ross Burton
2024-04-12 13:47   ` Marko, Peter
2024-04-12 16:41     ` Richard Purdie
2024-04-12 20:55       ` Marko, Peter
2024-04-10 16:18 ` Ross Burton
2024-04-10 18:04   ` Marko, Peter
2024-04-11 15:31     ` Francesco Dolcini
2024-04-11 18:48     ` Slater, Joseph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS1PR10MB569732EB0A58FF2C515A9B25FD072@AS1PR10MB5697.EURPRD10.PROD.OUTLOOK.COM \
    --to=peter.marko@siemens.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.