All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
	James Morse <james.morse@arm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Robert Richter <rric@kernel.org>,
	Khuong Dinh <khuong@os.amperecomputing.com>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC: Use string choice helper functions
Date: Sun, 23 Feb 2025 22:28:41 +0100	[thread overview]
Message-ID: <B4626391-D626-4539-93B3-9FB00F0EB713@linux.dev> (raw)
In-Reply-To: <20250213210510.GA212119@yaz-khff2.amd.com>

On 13. Feb 2025, at 22:05, Yazen Ghannam wrote:
> On Thu, Feb 13, 2025 at 09:10:28PM +0100, Thorsten Blum wrote:
>> On 13. Feb 2025, at 18:41, Yazen Ghannam wrote:
>>> On Sun, Feb 09, 2025 at 10:52:21PM +0100, Thorsten Blum wrote:
>>>> Remove hard-coded strings by using the str_enabled_disabled(),
>>>> str_yes_no(), str_write_read(), and str_plural() helper functions.
>>>> 
>>>> Add a space in "All DIMMs support ECC: yes/no" to improve readability.
>>>> 
>>>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>>>> ---
>>>> drivers/edac/amd64_edac.c | 47 +++++++++++++++++++--------------------
>>>> drivers/edac/debugfs.c    |  5 ++++-
>>>> drivers/edac/i5400_edac.c |  3 ++-
>>>> drivers/edac/i7300_edac.c |  7 +++---
>>>> drivers/edac/xgene_edac.c | 17 +++++++-------
>>>> 5 files changed, 42 insertions(+), 37 deletions(-)
>>>> 
>>> 
>>> Please do include a base commit id. This patch doesn't apply to
>>> ras/edac-for-next but does apply to mainline/master.
>> 
>> Ok. Should I rebase and resubmit or just for next time?
> 
> Just for next time I think.

This actually applies to ras/edac-for-next for me.

I just resend the patch with a base commit id anyway.

Thanks,
Thorsten


      reply	other threads:[~2025-02-23 21:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-09 21:52 [PATCH] EDAC: Use string choice helper functions Thorsten Blum
2025-02-10  8:20 ` Zhuo, Qiuxu
2025-02-13 17:41 ` Yazen Ghannam
2025-02-13 20:10   ` Thorsten Blum
2025-02-13 21:05     ` Yazen Ghannam
2025-02-23 21:28       ` Thorsten Blum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B4626391-D626-4539-93B3-9FB00F0EB713@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=khuong@os.amperecomputing.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rric@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.