diff for duplicates of <BANLkTikR2AwBdORYUdTCcAOPeMkKN7azQQ@mail.gmail.com> diff --git a/a/1.txt b/N1/1.txt index 39a9e5d..e620008 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ -2011/4/12 Rafa? Mi?ecki <zajec5@gmail.com>: +2011/4/12 Rafał Miłecki <zajec5@gmail.com>: > 2011/4/12 Greg KH <greg@kroah.com>: ->> On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafa? Mi?ecki wrote: +>> On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafał Miłecki wrote: >>> 2011/4/12 Greg KH <greg@kroah.com>: ->>> > Then in your release function, free the struct axi_device. ?It's that ->>> > simple. ?To try to free it before then would be wrong and cause +>>> > Then in your release function, free the struct axi_device. It's that +>>> > simple. To try to free it before then would be wrong and cause >>> > problems. >>> >>> This is because it is defined as: @@ -11,8 +11,8 @@ >> >> No way, seriously? >> ->> You can't do that, no static struct devices please. ?Make these dynamic ->> and everything will be fine. ?The -mm tree used to have a huge warning +>> You can't do that, no static struct devices please. Make these dynamic +>> and everything will be fine. The -mm tree used to have a huge warning >> if you ever tried to register a statically allocated struct, but that >> didn't really work out, but would have saved you a lot of time here, >> sorry. @@ -21,7 +21,7 @@ > > Well, I saw that along kernel, I had no idea there is anything wrong > about this. It seems more ppl do not know about this: -> struct radeon_ib ? ? ? ?ibs[RADEON_IB_POOL_SIZE]; +> struct radeon_ib ibs[RADEON_IB_POOL_SIZE]; > struct radeon_pm_clock_info clock_info[8]; > struct radeon_pm_profile profiles[PM_PROFILE_MAX]; > struct radeon_surface_reg surface_regs[RADEON_GEM_MAX_SURFACES]; @@ -51,4 +51,4 @@ Please point me to some place where I can read more about this. Some tips about coding style for such things, cases. -- -Rafa? +Rafał diff --git a/a/content_digest b/N1/content_digest index 77ef962..c7a54e2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -10,17 +10,29 @@ "ref\020110411233506.GA13240@kroah.com\0" "ref\0BANLkTi=cG3U8yXaQ6PusmNaWcr+AWv3e_w@mail.gmail.com\0" "From\0Rafa\305\202 Mi\305\202ecki <zajec5@gmail.com>\0" - "Subject\0[RFC][PATCH V3] axi: add AXI bus driver\0" + "Subject\0Re: [RFC][PATCH V3] axi: add AXI bus driver\0" "Date\0Tue, 12 Apr 2011 13:40:36 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Greg KH <greg@kroah.com>\0" + "Cc\0linux-wireless@vger.kernel.org" + John W. Linville <linville@tuxdriver.com> + George Kashperko <george@znau.edu.ua> + Arnd Bergmann <arnd@arndb.de> + Russell King <rmk@arm.linux.org.uk> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + b43-dev@lists.infradead.org + " Michael B\303\274sch <mb@bu3sch.de>" + linuxdriverproject <devel@linuxdriverproject.org> + Andy Botting <andy@andybotting.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + " Larry Finger <Larry.Finger@lwfinger.net>\0" "\00:1\0" "b\0" - "2011/4/12 Rafa? Mi?ecki <zajec5@gmail.com>:\n" + "2011/4/12 Rafa\305\202 Mi\305\202ecki <zajec5@gmail.com>:\n" "> 2011/4/12 Greg KH <greg@kroah.com>:\n" - ">> On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafa? Mi?ecki wrote:\n" + ">> On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" ">>> 2011/4/12 Greg KH <greg@kroah.com>:\n" - ">>> > Then in your release function, free the struct axi_device. ?It's that\n" - ">>> > simple. ?To try to free it before then would be wrong and cause\n" + ">>> > Then in your release function, free the struct axi_device. \302\240It's that\n" + ">>> > simple. \302\240To try to free it before then would be wrong and cause\n" ">>> > problems.\n" ">>>\n" ">>> This is because it is defined as:\n" @@ -28,8 +40,8 @@ ">>\n" ">> No way, seriously?\n" ">>\n" - ">> You can't do that, no static struct devices please. ?Make these dynamic\n" - ">> and everything will be fine. ?The -mm tree used to have a huge warning\n" + ">> You can't do that, no static struct devices please. \302\240Make these dynamic\n" + ">> and everything will be fine. \302\240The -mm tree used to have a huge warning\n" ">> if you ever tried to register a statically allocated struct, but that\n" ">> didn't really work out, but would have saved you a lot of time here,\n" ">> sorry.\n" @@ -38,7 +50,7 @@ ">\n" "> Well, I saw that along kernel, I had no idea there is anything wrong\n" "> about this. It seems more ppl do not know about this:\n" - "> struct radeon_ib ? ? ? ?ibs[RADEON_IB_POOL_SIZE];\n" + "> struct radeon_ib \302\240 \302\240 \302\240 \302\240ibs[RADEON_IB_POOL_SIZE];\n" "> struct radeon_pm_clock_info clock_info[8];\n" "> struct radeon_pm_profile profiles[PM_PROFILE_MAX];\n" "> struct radeon_surface_reg surface_regs[RADEON_GEM_MAX_SURFACES];\n" @@ -68,6 +80,6 @@ "tips about coding style for such things, cases.\n" "\n" "-- \n" - Rafa? + "Rafa\305\202" -29e88e06f96ac17e55cad12dd104e8c6191c6869f254973f8dd088ace99f83e6 +9ace65f5419e1596f782611c697b37997d1ad4c575b5a222440bcf09a0152133
diff --git a/a/content_digest b/N2/content_digest index 77ef962..174b730 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -9,7 +9,7 @@ "ref\0BANLkTinpKKRCrBik6-9C5WqcSDGuEt5yCw@mail.gmail.com\0" "ref\020110411233506.GA13240@kroah.com\0" "ref\0BANLkTi=cG3U8yXaQ6PusmNaWcr+AWv3e_w@mail.gmail.com\0" - "From\0Rafa\305\202 Mi\305\202ecki <zajec5@gmail.com>\0" + "From\0zajec5@gmail.com (Rafa\305\202 Mi\305\202ecki)\0" "Subject\0[RFC][PATCH V3] axi: add AXI bus driver\0" "Date\0Tue, 12 Apr 2011 13:40:36 +0200\0" "To\0linux-arm-kernel@lists.infradead.org\0" @@ -70,4 +70,4 @@ "-- \n" Rafa? -29e88e06f96ac17e55cad12dd104e8c6191c6869f254973f8dd088ace99f83e6 +8952d3aca90c066d9be1e644f91c3d06fcb17d580d4f1a9b02e379887cd24d41
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.