From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chen Date: Mon, 19 Jul 2004 02:05:46 +0000 Subject: Re: ppp MULTILINK issue / problem Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ppp@vger.kernel.org on 7/16/04 9:22 AM, Matthew N. Dodd at mdodd@patton.com wrote: i am not sure this is a good fix.... first of all, what version of ppp is this applicable to ? also, i put this fix in, and for single link (not multilink) it did not work (ioctl returning error).... i have not tried multilink, if it works for multilink, then the fix should be wrap around with if (multilink) { if (ioctl(ppp_fd, PPPIOCDISCONN) < 0) error("Couldn't detach from PPP unit %d: %m", ifunit); } ??? however, there is a PPIOCDETACH a few lines below... does that not do DISCONN ??? > linux-ppp-owner@vger.kernel.org wrote: >> Subject: ppp MULTILINK issue / problem > ... >> now i am testing "UNBUNDLING" of the link.... if i unplug >> the one of the modem (not the master link), i do not see >> the IP traffic anymore, though i do see data on the serial >> link (i put a serial line monitor on the serial port), >> but no more IP packets coming out of PPP > ... > > I just ran into this and discovered that PPPIOCDISCONN is never being > called when pppd brings the link down. > > This causes the MP fragmentation queue to stall. > > Calling this IOCTL in sys-linux.c:generic_disestablish_ppp() fixes the > problem for me. > > void generic_disestablish_ppp(int dev_fd) > { > if (new_style_driver) { > + if (ioctl(ppp_fd, PPPIOCDISCONN) < 0) > + error("Couldn't detach from PPP unit %d: %m", ifunit); > close(ppp_fd); > ppp_fd = -1; > if (demand) { > > -- > Matthew N. Dodd > Software Engineer, Patton Electronics > 7622 Rickenbacker Dr., Gaithersburg, MD 20879 > (301) 975-1000x184 >