From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: Re: Re: [PATCH] kexec: framework and i386 (Take XIV)
Date: Tue, 05 Sep 2006 06:45:35 +0900
Message-ID: <BDC6D06B746C01takebe_akio@jp.fujitsu.com>
References: <20060901025610.GE31034@verge.net.au>
	<A5C6CDA26D3151takebe_akio@jp.fujitsu.com>
	<A6C6CDA30C4336takebe_akio@jp.fujitsu.com>
	<20060901102116.GN17801@verge.net.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20060901102116.GN17801@verge.net.au>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Horms <horms@verge.net.au>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>, Kazuo Moriwaka <moriwaka@valinux.co.jp>, xen-devel@lists.xensource.com, "Zou, Nanhai" <nanhai.zou@intel.com>, Akio Takebe <takebe_akio@jp.fujitsu.com>, Isaku Yamahata <yamahata@valinux.co.jp>, Magnus Damm <magnus@valinux.co.jp>, Mark Williamson <mark.williamson@cl.cam.ac.uk>, xen-ia64-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Hi, Horms

I tested the following patch with Horms kexec patch.

My tests is:
  push NMI bottun after loading kdump kernel.
  
The results is:
  OK, I could get vmcore

diff -r b688d4a68a3e xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c      Tue Aug 22 14:59:16 2006 +0100
+++ b/xen/arch/x86/traps.c      Tue Sep 05 06:37:49 2006 +0900
@@ -105,6 +105,8 @@ static int debug_stack_lines = 20;
 static int debug_stack_lines = 20;
 integer_param("debug_stack_lines", debug_stack_lines);
 
+extern void crash_kexec(struct cpu_user_regs *regs);
+
 #ifdef CONFIG_X86_32
 #define stack_words_per_line 8
 #define ESP_BEFORE_EXCEPTION(regs) ((unsigned long *)&regs->esp)
@@ -1611,8 +1613,10 @@ asmlinkage void do_nmi(struct cpu_user_r
             mem_parity_error(regs);
         else if ( reason & 0x40 )
             io_check_error(regs);
-        else if ( !nmi_watchdog )
+        else if ( !nmi_watchdog ){
+            crash_kexec(NULL);
             unknown_nmi_error((unsigned char)(reason&0xff));
+        }
     }
 }
 


Best Regards,

Akio Takebe

>On Fri, Sep 01, 2006 at 05:45:59PM +0900, Akio Takebe wrote:
>> >Hi, Horms
>> >
>> >>That seems like a good idea to me. Though I think you are missing { }.
>> >>Can you test to see if this works?
>> >Oops, You're right. But I think unknown_nmi_error() is not called,
>> >because crash_kexec() is called before that.
>> Sorry.
>> In the only case of CONFIG_KEXEC=y, the above is right.
>
>Yes, I think that is the case. I will put your patch into the kexec
>series, as I think that it is a worthy addition.
>
>-- 
>Horms
>  H: http://www.vergenet.net/~horms/
>  W: http://www.valinux.co.jp/en/
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel