Re: [OE-core] [PATCH v2] adwaita-icon-theme: 43 -> 45.0

[Markus Volk <f_l_k@t-online.de>]

[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]

The refmanual says about allarch:
Unlike some distro recipes (e.g. Debian), OpenEmbedded recipes that 
produce packages that depend on tunings through use of the RDEPENDS and 
TUNE_PKGARCH variables, should never be configured for all 
architectures using allarch. This is the case even if the recipes do 
not produce architecture-specific output.

gtk-icon-cache.bbclass adds RDEPENDS and that probably makes the 
package incompatible with allarch
'gtk_update_icon_cache' is run in meson automatically:
<https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/blob/master/meson.build?ref_type=heads#L89>

I patched meson to not run gtk_update_icon_cache and the test also 
passed.
But this brings me back to my first idea, that it might be the right 
thing to do to remove inherit allarch?

On Thu, Sep 21 2023 at 07:36:39 PM +02:00:00, Alexander Kanavin 
<alex.kanavin@gmail.com> wrote:
> On Thu, 21 Sept 2023 at 17:51, Markus Volk <f_l_k@t-online.de 
> <mailto:f_l_k@t-online.de>> wrote:
>>  How did you trace it? That doesn't make sense given what the test 
>> does, and the task where diverge begins.
>> 
>>  but still the test failed. In the next step I excluded inherit 
>> allarch and the test succeeded
>> 
>>  Looking at allarch.bbclass, this was the most suspicious part to me 
>> and first thing I tried was commenting out
>>  #addhandler allarch_package_arch_handler
> 
> I see, thanks. Unfortunately I think you went down the wrong path.
> 
> The recipe is meant to be allarch since it doesn't build anything for
> the target and only installs pre-built data which is identical on all
> targets. This improves sstate reuse for one thing. This worked fine
> until this version update, but after the version update the signature
> for the newly added task write_config (which I think comes from meson)
> differs depending on target. Something creeps in there which varies
> between targets, so you need to for example use bitbake-diffsigs to
> compare the signatures (the test prints what they are, and
> bitbake-diffsigs will tell you what changed).
> 
> Alex


[-- Attachment #2: Type: text/html, Size: 2457 bytes --]