From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: u-boot@lists.denx.de, Andre Przywara <andre.przywara@arm.com>
Cc: Tom Rini <trini@konsulko.com>, Chen-Yu Tsai <wens@kernel.org>,
Paul Kocialkowski <contact@paulk.fr>,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 2/5] sunxi: spl: spi: Clean up SPI0 pinmux setting
Date: Sat, 16 May 2026 07:04:37 +0200 [thread overview]
Message-ID: <BMPMpqHgSfSjFLCZJY9zjg@gmail.com> (raw)
In-Reply-To: <20260515234601.15431-3-andre.przywara@arm.com>
Dne sobota, 16. maj 2026 ob 01:45:58 Srednjeevropski poletni čas je Andre Przywara napisal(a):
> The function to set the pinmux for the Port C SPI0 pins was looking more
> like a logic puzzle from a magazine than something that readers could
> understand and extend.
>
> Replace the convoluted pinmux setup, grouped by pin, with a simple array
> of the four pins involved, and just initialise this array at build time,
> based on the selected SoC.
>
> This makes it easy to see which pins are needed, and even easier to extend.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
next prev parent reply other threads:[~2026-05-16 5:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 23:45 [PATCH v2 0/5] sunxi: A523: Add SPI support Andre Przywara
2026-05-15 23:45 ` [PATCH v2 1/5] spi: sunxi: add support for A523 SPI controller Andre Przywara
2026-05-15 23:45 ` [PATCH v2 2/5] sunxi: spl: spi: Clean up SPI0 pinmux setting Andre Przywara
2026-05-16 5:04 ` Jernej Škrabec [this message]
2026-05-15 23:45 ` [PATCH v2 3/5] sunxi: spl: spi: Add support for Allwinner A523 Andre Przywara
2026-05-15 23:46 ` [PATCH v2 4/5] sunxi: configs: Radxa Cubie A5E: enable SPI Andre Przywara
2026-05-15 23:46 ` [PATCH v2 5/5] sunxi: configs: OrangePi 4A: " Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BMPMpqHgSfSjFLCZJY9zjg@gmail.com \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=contact@paulk.fr \
--cc=linux-sunxi@lists.linux.dev \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.