From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 794C2C83F15 for ; Wed, 30 Aug 2023 14:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TRBV1w8DM6wfugI53CFBGiW65TV/F55M4DS0qpFI4C0=; b=jzj8H6nMWSSsWNsHsr1TL/drOf Djks/tIIv7wdEnSfmrmhU77nuPlebLG+eWgwVe61SCdhepNj6G39ljYzUOCTDzOBZKVSAFMwCbWXl 7PNp8lq9DjN95t62mhSNJI5ZW3J7uCihjpM2nIu5OoLt2dug0Xg6MXoaZD4SszSgohIoOqld+OJOW 8nfFORokBOYgtCax0/yy10BwAzTOQd1w5IYA4ByY5narSAJjQvanLXNDE1/nv/vhFQ1EtEpQ9OkSd AK0L5SVJqKBizaIMAYu3ayOFExC2f2k9sOEyD6MY7JxtrO5IZuY5xJqTG4vdlIh0yf0amVpLLKflp GLQyEPew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbM2j-00Df3V-2s; Wed, 30 Aug 2023 14:19:37 +0000 Received: from relay03.th.seeweb.it ([2001:4b7a:2000:18::164]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbM2h-00Df2c-0B for linux-arm-kernel@lists.infradead.org; Wed, 30 Aug 2023 14:19:36 +0000 Received: from [192.168.2.144] (bband-dyn191.178-41-225.t-com.sk [178.41.225.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 635EC20035; Wed, 30 Aug 2023 16:19:29 +0200 (CEST) Date: Wed, 30 Aug 2023 16:19:23 +0200 From: Martin Botka Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions To: Sudeep Holla Cc: Mark Rutland , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka Message-Id: In-Reply-To: References: <20230830-smccc_export-v1-1-6ecc7661bc94@somainline.org> X-Mailer: geary/43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_071935_274930_F6B733B1 X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIHBhdGNoZXMgdXNpbmcgdGhpcyBhcmUgc3RpbGwgV0lQIGJ1dCB0aGUgYmFzaWMgcG9pbnQg aXMgdGhhdCBINjE2IApoYXMgMiBkaWUgcmV2aXNpb25zIChBbmQgdGhvc2UgaGF2ZQpjb3VwbGUg b2Ygb3RoZXIgdmVyc2lvbnMgdGhlbXNlbHZlcykgdGhhdCByZXF1aXJlIGRpZmZlcmVudCB1ViBh bmQgc29tZSAKZnJlcXVlbmNpZXMgYXJlIGJsYWNrbGlzdGVkIG9uIHRob3NlCnZlcnNpb25zLgoK VGhlIGRyaXZlciBpcyB1c2luZyB0aGVzZSBmdW5jdGlvbnMgdG8gcmVhZCB0aGUgcmV2aXNpb24g KE5vdCB0aGUgCnZlcnNpb24uIEl0IGp1c3QgbG9va2VkIGxpa2UgdGhlIGxvZ2ljYWwKdGhpbmcg dG8gZXhwb3J0IGJvdGggYW5kIEFuZHJlIGNvbmZpcm1lZC4gV2UgY2FuIG9mYyBkcm9wIHRoZSB2 ZXJzaW9uIApzeW1ib2wgZXhwb3J0IGlmIG5lZWQgYmUpIGFuZCByZWFkcwp0cm91Z2ggdGhlIE9Q UCB0YWJsZSBhbmQgc2VsZWN0cyB0aGUgc3VwcG9ydGVkIGZyZXF1ZW5jaWVzIGFuZCB1ViBmb3Ig CnRoZSBjaGlwIGl0cyBydW5uaW5nIG9uIDopCgpJIHdpbGwgdHJ5IHRvIGdldCB0aGUgY3B1ZnJl cSBwYXRjaGVzIGluIG9yZGVyIGluIHRoZSB1cGNvbWluZyBkYXlzIGFuZCAKSSB3aWxsIENjIHlv dSBpbiB0aG9zZSBhcyB3ZWxsICsKcG9zdCBhIGxpbmsgdG8gdGhlbSBpbiB0aGlzIHRocmVhZCA6 KQoKQ2hlZXJzLApNYXJ0aW4KCk9uIFdlZCwgQXVnIDMwIDIwMjMgYXQgMDM6MDU6MDkgUE0gKzAx OjAwOjAwLCBTdWRlZXAgSG9sbGEgCjxzdWRlZXAuaG9sbGFAYXJtLmNvbT4gd3JvdGU6Cj4gCj4g Cj4gT24gV2VkLCBBdWcgMzAsIDIwMjMgYXQgMjoyNOKAr1BNIE1hcnRpbiBCb3RrYSAKPiA8bWFy dGluLmJvdGthQHNvbWFpbmxpbmUub3JnPiB3cm90ZToKPj4gYXJtX3NtY2NjX2dldF9zb2NfaWRf dmVyc2lvbiBhbmQgYXJtX3NtY2NjX2dldF9zb2NfaWRfcmV2aXNpb24KPj4gIG5lZWQgdG8gYmUg ZXhwb3J0ZWQgc28gdGhleSBjYW4gYmUgdXNlZCBieSBtb2R1bGVzLgo+PiAgQ3VycmVudGx5IHN1 bjUwaSBjcHUgZnJlcSBkcml2ZXIgaXMgcGxhbm5pbmcgdG8gdXNlIHRoZXNlIGZ1bmN0aW9ucy4K PiAKPiBJIGFtIG5vdCBhZ2FpbnN0IGV4cG9ydGluZyB0aGVzZSBidXQgcGxlYXNlIHBvc3QgYWxv bmcgd2l0aCB0aGUgCj4gcGF0Y2hlcyB1c2luZyB0aGVzZQo+IGV4cG9ydGVkIHN5bWJvbHMgc28g dGhhdCBubyBvbmUgY29tcGxhaW5zIGFib3V0IHlvdSBleHBvcnRpbmcgdGhlIAo+IHN5bWJvbHMg bWVudGlvbmluZwo+IHNvbWUgcGF0Y2hlcyB0aGF0IG1heSBvciBtYXkgbm90IGFwcGVhciBpbiB0 aGUgZnV0dXJlLgo+IAo+IC0tCj4gUmVnYXJkcywKPiBTdWRlZXAKCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CA8C83F25 for ; Wed, 30 Aug 2023 19:29:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344188AbjH3T0p convert rfc822-to-8bit (ORCPT ); Wed, 30 Aug 2023 15:26:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244997AbjH3OTg (ORCPT ); Wed, 30 Aug 2023 10:19:36 -0400 Received: from relay04.th.seeweb.it (relay04.th.seeweb.it [5.144.164.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 565A8122 for ; Wed, 30 Aug 2023 07:19:32 -0700 (PDT) Received: from [192.168.2.144] (bband-dyn191.178-41-225.t-com.sk [178.41.225.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 635EC20035; Wed, 30 Aug 2023 16:19:29 +0200 (CEST) Date: Wed, 30 Aug 2023 16:19:23 +0200 From: Martin Botka Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions To: Sudeep Holla Cc: Mark Rutland , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka Message-Id: In-Reply-To: References: <20230830-smccc_export-v1-1-6ecc7661bc94@somainline.org> X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patches using this are still WIP but the basic point is that H616 has 2 die revisions (And those have couple of other versions themselves) that require different uV and some frequencies are blacklisted on those versions. The driver is using these functions to read the revision (Not the version. It just looked like the logical thing to export both and Andre confirmed. We can ofc drop the version symbol export if need be) and reads trough the OPP table and selects the supported frequencies and uV for the chip its running on :) I will try to get the cpufreq patches in order in the upcoming days and I will Cc you in those as well + post a link to them in this thread :) Cheers, Martin On Wed, Aug 30 2023 at 03:05:09 PM +01:00:00, Sudeep Holla wrote: > > > On Wed, Aug 30, 2023 at 2:24 PM Martin Botka > wrote: >> arm_smccc_get_soc_id_version and arm_smccc_get_soc_id_revision >> need to be exported so they can be used by modules. >> Currently sun50i cpu freq driver is planning to use these functions. > > I am not against exporting these but please post along with the > patches using these > exported symbols so that no one complains about you exporting the > symbols mentioning > some patches that may or may not appear in the future. > > -- > Regards, > Sudeep