From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [Xen-devel] [PATCH] xencomm, xenmem and hypercall continuation Date: Fri, 10 Nov 2006 09:57:44 +0000 Message-ID: References: <20061110084528.GH19699%yamahata@valinux.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061110084528.GH19699%yamahata@valinux.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-ppc-devel-bounces@lists.xensource.com Errors-To: xen-ppc-devel-bounces@lists.xensource.com To: Isaku Yamahata Cc: xen-ppc-devel@lists.xensource.com, xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 10/11/06 08:45, "Isaku Yamahata" wrote: > - introduce guest_handle_add_offset_after_continuatiton() and > replace guest_handle_add_offset() in memory.c with it. > leave do_multicall() and guest_console_write() as is. This is the best option I think. But I'm loathe to make it part of the guest_handle API. We should avoid getting into this mess in the first place for future hypercalls, so this will be a memory-specific function. We should stick it at the top of memory.c, with a comment and make it a no-op dependent on something like ARCH_HAS_XENCOMM (or just __ia64__ || __powerpc__ would be fine, actually, since it's just one place). -- Keir