From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Fix core dumps of guests > 2 GB in size on i386 Date: Fri, 17 Nov 2006 13:47:12 +0000 Message-ID: References: <20061117121243.GA11444@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061117121243.GA11444@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 17/11/06 12:12, "Daniel P. Berrange" wrote: > Well there are two methods in libxc which expose a size_t argument so the > implicit method will break ABI changing these from 32 to 64 bits. > > xenctrl.h:int xc_tbuf_enable(int xc_handle, size_t cnt, unsigned long *mfn, > xenctrl.h:int xc_acm_op(int xc_handle, int cmd, void *arg, size_t arg_size); It'd be better probably to replace with explicit types and avoid off_t/size_t confusion at all. Maybe uint64_t. -- Keir