Re: Re: [PATCH] add check for python-devel to tools build

[Keir Fraser <keir@xensource.com>]

Please re-post.

On 22/11/06 08:10, "Jan Beulich" <jbeulich@novell.com> wrote:

> Keir - will you integrate this, or should I re-post a patch?
> 
>>>> Ewan Mellor <ewan@xensource.com> 21.11.06 18:23 >>>
> On Tue, Nov 21, 2006 at 05:10:43PM +0000, Daniel P. Berrange wrote:
> 
>> On Tue, Nov 21, 2006 at 05:06:49PM +0000, Ewan Mellor wrote:
>>> On Tue, Nov 21, 2006 at 10:51:49AM -0600, Anthony Liguori wrote:
>>> 
>>>> Jan Beulich wrote:
>>>>> Again, this must be given exec permission after applying.
>>>>> 
>>>>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>>>>> 
>>>>> Index: 2006-11-17/tools/check/check_python_devel
>>>>> ===================================================================
>>>>> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
>>>>> +++ 2006-11-17/tools/check/check_python_devel 2006-11-21
>>>>> 12:03:08.000000000 +0100
>>>>> @@ -0,0 +1,13 @@
>>>>> +#!/bin/bash
>>>>> +# CHECK-BUILD
>>>>> +
>>>>> +function error {
>>>>> +    echo
>>>>> +    echo "  *** Check for python development environment FAILED"
>>>>> +    exit 1
>>>>> +}
>>>>> +
>>>>> +lib=lib
>>>>> +test "$(uname -m)" != x86_64 || lib=lib64
>>>>> +set -e
>>>>> +[ -e /usr/$lib/python/config/Makefile ] || error
>>>> 
>>>> There is no /usr/lib/python/config/Makefile on Ubuntu.  You should be
>>>> okay if you also check for /usr/lib/python-2.[345]/config/Makefile.
>>> 
>>> My Debian box has /usr/lib/python2.3.  How about
>>> /usr/lib/python*/config/Makefile?  That should be OK, and has the advantage
>>> of
>>> including /usr/lib/python.
>> 
>> Using wildcards though will not be reliable. eg I have both python 2.3 and
>> 2.4
>> installed, but python 2.4 is the version I'm deploying Xen against. This test
>> won't catch the case where I have  python-devel = 2.3, but don't have the
>> python-devel == 2.4 installed. We want to make sure we only check against the
>> version we're actually building against.
> 
> python -c '
> import os.path, sys
> for p in sys.path:
>   if os.path.exists(p + "/config/Makefile"):
>     sys.exit(0)
> sys.exit(1)
> '
> 
> Ewan.