From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: hvm_decode() questions Date: Fri, 24 Nov 2006 14:08:16 +0000 Message-ID: References: <456709DE.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <456709DE.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 24/11/06 14:03, "Jan Beulich" wrote: > 1) single-byte opcode 0x87 (xchg): What is this strange conditional > > if ( ((*(opcode+1)) & 0xc7) == 5 ) > > supposed to address? xchg has absolutely symmetric operands. > > 2) two-byte opcode 0xB7 (movzx): What is this dependency on rex > bit 3 doing here? Apparently this was based on Intel's (broken) > documentation - the source operand is always 16 bits. > > Unless someone can explain these, I'll send a patch to remove them. Yes, these can both be removed. -- Keir