From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Avoid triggering the softlockup BUG when offline for too long. Date: Mon, 27 Nov 2006 10:21:54 +0000 Message-ID: References: <20061124131022.GB7171@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061124131022.GB7171@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Glauber de Oliveira Costa , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 24/11/06 13:10, "Glauber de Oliveira Costa" wrote: > After being offline for a long time, the softlockup watchdog triggers > a BUG() on our faces. This is expected, as in fact, we spent more than > a fixed 10*HZ amount of time without touching the watchdog. > > However, by inspecting the contents of RUNSTATE_offline, we can gain > awareness of the fact, and do better than that. This patch fixes it. > > Signed-off-by: Glauber de Oliveira Costa Would 'stolen' not be a good enough thing to test? Presumably this is really just dealing with xm pause/unpause (a single long offline) so this simpler fix would work just as well? -- Keir