From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Re: [Patch] Constrain DMADOM/swiotlb allocations to 1G phys to fix b44 NIC driver Date: Tue, 28 Nov 2006 16:01:20 +0000 Message-ID: References: <1164728964.10380.19.camel@sisko.scot.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1164728964.10380.19.camel@sisko.scot.redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Stephen C. Tweedie" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 28/11/06 15:49, "Stephen C. Tweedie" wrote: >> It turns out that this 2GB / 31-bit constraint is magically hardcoded in >> a couple of places rather than being read correctly from config.h. So >> this patch fixes that; changes config.h to specify a 1GB / 30-bit >> constraint for the DMADOM heap; and changes the x86/x86_64 swiotlb to >> request a 30-bit constraint for allocations of the swiotlb memory. > > The 30 bit constraint is enough to let b44 work. But there are a number > of sound cards which require a 28-bit DMA mask (256MB max physical > addressable memory). 1GB seems reasonably safe, but I'm much less > comfortable with restricting DMADOM to 256MB by default. Does anyone > have any strong feelings about shifting this? What other users of > DMADOM are there that might overflow if we restrict it even further? We could make bit-width of the DMA allocator in Xen a boot parameter. And we could make the bit-width of the SWIOTLB allocations a Linux boot parameter. Then those that care can do the necessary cmdline hacking. I'd be tempted to recommend this for b44 users too, and leave the default bit-width as 31. I'm not convinced there can be that many who are using Xen. But maybe the chipset is more common than I think. -- Keir