From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Avoid triggering the softlockup BUG when offline for too long. Date: Wed, 29 Nov 2006 12:18:12 +0000 Message-ID: References: <20061129120859.GB23434@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061129120859.GB23434@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Glauber de Oliveira Costa , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 29/11/06 12:08, "Glauber de Oliveira Costa" wrote: > [LINUX] Avoid triggering the softlockup BUG when offline for too long. > > After being offline for a long time, the softlockup watchdog triggers > a BUG() on our faces. This is expected, as in fact, we spent more than > a fixed 10*HZ amount of time without touching the watchdog. > > However, by inspecting the contents of stolen inside timer irq handler, > we can gain awareness of the fact, and do better than that. > This patch fixes it. Thanks. I changed the threshold to 5*HZ just to avoid marginal cases where we might be offlined for just less than 10 seconds, and then if the per-cpu watchdog process hasn't run for a second or two before we were offlined then that would push us over the edge to print a warning. 5*HZ is much more comfortable. -- Keir