From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] Enable uppercase letters to be entered in
	QEMU monitor terminal
Date: Wed, 29 Nov 2006 16:09:32 +0000
Message-ID: <C193613C.53EB%keir@xensource.com>
References: <20061129154841.GA16682@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20061129154841.GA16682@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Daniel P. Berrange" <berrange@redhat.com>, Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org




On 29/11/06 15:48, "Daniel P. Berrange" <berrange@redhat.com> wrote:

>> Doesn't this eat the shift/caps key events even when not in qemu monitor
>> mode? What if the guest has shortcut key combos involving those keys, for
>> example?
> 
> Re-checking the patch I believe its already doing the correct thing.
> 
> The do_key_event method is broken into 2 halfs. In the first half, the
> keysyms are sent to either the guest OS, or the monitor. In the second
> half the shift/caps/ctrl/alt state is being tracked. So the code I added
> for tracking shift/caps does not interfere with the earlier code which
> actually sends the key press to the guest OS.

Okay, I'll read the code more carefully. :-)

 -- keir