From: Keir Fraser <keir@xensource.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] ARCH_HAS_DEV_MEM_MMAP_MEM fix
Date: Fri, 01 Dec 2006 09:56:41 +0000 [thread overview]
Message-ID: <C195ACD9.55A3%keir@xensource.com> (raw)
In-Reply-To: <1164926187.6117.29.camel@lappy>
On 30/11/06 22:36, "Alex Williamson" <alex.williamson@hp.com> wrote:
> We can't really define our own mmap_mem external from
> driver/xen/char/mem.c as long as drivers/char/mem.c is defining a static
> version. Patch below solves the problem. Thanks,
mmap_mem() in drivers/char/mem.c is still used by mmap_kmem(). We'll get a
compile warning if the local static definition of mmap_mem() is removed
(plus I think the native mmap_mem is the right one to use for mmap_kmem, at
least on x86). Perhaps we should rename the Xen mmap_mem to xen_mmap_mem?
-- Keir
next prev parent reply other threads:[~2006-12-01 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 22:36 [PATCH] ARCH_HAS_DEV_MEM_MMAP_MEM fix Alex Williamson
2006-12-01 9:56 ` Keir Fraser [this message]
2006-12-01 13:15 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C195ACD9.55A3%keir@xensource.com \
--to=keir@xensource.com \
--cc=alex.williamson@hp.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.