From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Reduce overhead in find_domain_by_id() [0/2] Date: Thu, 07 Dec 2006 12:01:46 +0000 Message-ID: References: <08CA2245AFCF444DB3AC415E47CC40AF5086EA@G3W0072.americas.hpqcorp.net> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <08CA2245AFCF444DB3AC415E47CC40AF5086EA@G3W0072.americas.hpqcorp.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Santos, Jose Renato G" , Keir Fraser , "Apparao, Padmashree K" , xen-devel@lists.xensource.com Cc: "Turner, Yoshio" , Jose Renato Santos , G John Janakiraman List-Id: xen-devel@lists.xenproject.org On 7/12/06 03:49, "Santos, Jose Renato G" wrote: > Can't think of anything else. If you want I can remove these and submit > a revised patch. > It seems that there is not much more we could remove. Not sure if you > have something else in mind... I suppose the patch isn't actually as big as I first imagined. I'll review it and probably apply it pretty much as is. It's just that RCU has always seemed rather over complicated to me (lots of different queues, for example) for what should be a rather simple concept to implement. This is possibly just ignorance on my part. :-) As for per-cpu refcounts, I suspect a better scheme would be find_domain_by_id_noref(). Idea being that often we take a reference for a short period of time (in particular, scope of one function) and with delayed destruction we can now safely use a found domain pointer with no refcnt increment. -- Keir