From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] Re: Re: [PATCH 2/2] PV framebuffer
Date: Thu, 14 Dec 2006 13:30:46 +0000
Message-ID: <C1A70286.6139%keir@xensource.com>
References: <87ejr21wmy.fsf@pike.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <87ejr21wmy.fsf@pike.pond.sub.org>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Markus Armbruster <armbru@redhat.com>, Keir Fraser <keir@xensource.com>
Cc: Atsushi SAKAI <sakaia@jp.fujitsu.com>, xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 14/12/06 12:37, "Markus Armbruster" <armbru@redhat.com> wrote:

>> The lock is used in fb_ops, vm_ops and kthread contexts. None of these are
>> executed in IRQ context so irqsave is not needed. I'll remove it. I'm not
>> sure whether you can call zap_page_range() even with a spinlock held
>> though...
>> 
>>  -- Keir
> 
> You can't.  This was spotted just yesterday in our internal review.
> I'm working on a fix.  If you could hold the removal of irqsave for a
> bit, that would avoid merge conflicts.

Too late I'm afraid.

If you come up with a reasonable fix before 3.0.4 goes out it'd be nice to
slip a fix in if it's not too big.

 -- Keir