All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: Markus Armbruster <armbru@redhat.com>, Keir Fraser <keir@xensource.com>
Cc: Atsushi SAKAI <sakaia@jp.fujitsu.com>,
	xen-devel@lists.xensource.com,
	xen-ia64-devel@lists.xensource.com
Subject: Re: [PATCH][PVFB][LINUX] Fix possible sleep while holding spinlock
Date: Fri, 15 Dec 2006 18:06:13 +0000	[thread overview]
Message-ID: <C1A89495.6290%keir@xensource.com> (raw)
In-Reply-To: <87zm9pt8qm.fsf@pike.pond.sub.org>

On 15/12/06 16:38, "Markus Armbruster" <armbru@redhat.com> wrote:

> This patch fixes the locking, but leaves open a race between
> xenfb_update_screen() and do_no_page().  See the source code for a
> detailed explanation of how it works, and where it fails.

That's a bit of a shame. Is there any way we could use do_file_page() and
have a populate hook (which gets to install the PTE itself)? Or are there
lots of assumptions about VMAs that would take this path, assert
VM_NONLINEAR, etc?

 -- Keir

  reply	other threads:[~2006-12-15 18:06 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-10  8:54 [PATCH 2/2] PV framebuffer Markus Armbruster
2006-11-12 14:20 ` Steven Smith
2006-11-14 14:01   ` Markus Armbruster
2006-11-15 12:18     ` Steven Smith
2006-11-15 17:46       ` Markus Armbruster
2006-11-16 16:13         ` Markus Armbruster
2006-11-17 13:23 ` Markus Armbruster
2006-11-17 13:26   ` Markus Armbruster
2006-11-22 11:49   ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-11-22 13:46     ` [PATCH] " Markus Armbruster
2006-11-24  5:00       ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-11-24  8:10         ` [PATCH] " Markus Armbruster
2006-11-24  8:48           ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-11-28 13:04           ` Atsushi SAKAI
2006-11-28 13:55             ` [PATCH] " Markus Armbruster
2006-11-29 13:08               ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-12-01 12:35               ` Atsushi SAKAI
2006-12-01 18:03                 ` [PATCH] " Markus Armbruster
2006-12-04  8:46                   ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-12-04 19:44                     ` [PATCH] " Markus Armbruster
2006-12-05 12:01                       ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-12-05 17:32                         ` [PATCH] " Markus Armbruster
2006-12-07  0:55                           ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-12-07  7:58                             ` [PATCH] " Markus Armbruster
2006-12-12 11:54                               ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-12-12 12:23                                 ` [PATCH] " Markus Armbruster
2006-12-13  2:18                                   ` Atsushi SAKAI
2006-12-14 10:58                                   ` [PATCH] Re: [Xen-devel] " Atsushi SAKAI
2006-12-14 11:30                                     ` [PATCH] " Keir Fraser
2006-12-14 12:37                                       ` Markus Armbruster
2006-12-14 13:30                                         ` Keir Fraser
2006-12-15 16:38                                           ` [PATCH][PVFB][LINUX] Fix possible sleep while holding spinlock Markus Armbruster
2006-12-15 18:06                                             ` Keir Fraser [this message]
2006-12-15 18:35                                               ` Markus Armbruster
2006-12-19  2:52                                             ` Atsushi SAKAI
2006-12-19  7:49                                               ` Markus Armbruster
2006-12-19  8:17                                                 ` Atsushi SAKAI
2007-01-10  8:50                                                   ` Markus Armbruster
2006-11-28 15:36             ` [PATCH] Re: Re: [PATCH 2/2] PV framebuffer Stephen C. Tweedie
2006-11-24  8:05   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C1A89495.6290%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=armbru@redhat.com \
    --cc=sakaia@jp.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xen-ia64-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.