From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [Patch] cleanup pciback_reset_device
Date: Mon, 18 Dec 2006 09:33:33 +0000
Message-ID: <C1AC10ED.5FF5%keir@xensource.com>
References: <2AC72285D84C8Dtakebe_akio@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <2AC72285D84C8Dtakebe_akio@jp.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Akio Takebe <takebe_akio@jp.fujitsu.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 18/12/06 9:21 am, "Akio Takebe" <takebe_akio@jp.fujitsu.com> wrote:

> This patch is for cleanup of pciback_reset_device.
> is_enabled=0 and is_busmaster=0 are not necessary
> because pci_disable_device() do them.

If you are zapping the command register then doesn't it makes sense to zap
the software flags relating to that at the same time, even if that sometimes
happens to be redundant? It certainly means we can be sure they won't get
out of sync.

 -- Keir