From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] Configurable keyboard mapping for HVM
Date: Mon, 18 Dec 2006 11:26:40 +0000
Message-ID: <C1AC2B70.63DF%keir@xensource.com>
References: <4586721E.1070902@inria.fr>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4586721E.1070902@inria.fr>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Guillaume Rousse <Guillaume.Rousse@inria.fr>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

What happens here if 'keyboard' is undefined in the s-expression?

 -- Keir

On 18/12/06 10:49, "Guillaume Rousse" <Guillaume.Rousse@inria.fr> wrote:

> Current keyboard mapping is hardcoded to en-US in image.py. Attached
> patch make this value a configurable option.
> diff -Naur xen-3.0.3_0-src/tools/python/xen/xend/image.py
> xen-3.0.3_0-src.allow_keyboard_mapping/tools/python/xen/xend/image.py
> --- xen-3.0.3_0-src/tools/python/xen/xend/image.py 2006-10-15
> 14:22:03.000000000 +0200
> +++ 
> xen-3.0.3_0-src.allow_keyboard_mapping/tools/python/xen/xend/image.py 2006-12-
> 18 11:45:22.000000000 +0100
> @@ -361,11 +361,12 @@
>              vncdisplay = sxp.child_value(config, 'vncdisplay',
>                                           int(self.vm.getDomid()))
>              vncunused = sxp.child_value(config, 'vncunused')
> +            keyboard = sxp.child_value(config, 'keyboard')
>              if vncunused:
>                  ret += ['-vncunused']
>              else:
>                  ret += ['-vnc', '%d' % vncdisplay]
> -            ret += ['-k', 'en-us']
> +            ret += ['-k', keyboard]
>              vnclisten = sxp.child_value(config, 'vnclisten')
>              if not(vnclisten):
>                  vnclisten =
> xen.xend.XendRoot.instance().get_vnclisten_address()
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel