From: Keir Fraser <keir@xensource.com>
To: Jimi Xenidis <jimix@watson.ibm.com>, Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays
Date: Mon, 18 Dec 2006 17:55:59 +0000 [thread overview]
Message-ID: <C1AC86AF.6454%keir@xensource.com> (raw)
In-Reply-To: <31010730-4AB4-48CA-BA8D-F281E6B4C9FC@watson.ibm.com>
On 18/12/06 16:50, "Jimi Xenidis" <jimix@watson.ibm.com> wrote:
>> another
>> a uint64_t. Perhaps we should fix so they pass down 8-bit units (as
>> the type
>> of xenctl_cpumap_t would suggest) and then we could have
>> byte_to_long_bitmap
>> and long_to_byte_bitmap in Xen
>
> Are you suggesting to still use bits in the bytes?
> If so, then do you want "C" ordering in the byte or arch bit ordering?
> Perhaps we simply to us the byte array as a list of CPU numbers, with
> -1 to terminate?
I mean bits 8k to 8k+7 inclusive are contained in byte at offset k in the
cpumap, and in the obvious order (8k is least significant bit; 8k+7 is most
significant). This is the byte-oriented bitmap type that your bitops.h goes
on about. Since xenctl_cpumap_t is defined as a byte array and byte count,
this interpretation would make sense.
-- Keir
next prev parent reply other threads:[~2006-12-18 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-17 17:53 [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays Jimi Xenidis
2006-12-18 9:26 ` Keir Fraser
2006-12-18 16:50 ` Jimi Xenidis
2006-12-18 17:55 ` Keir Fraser [this message]
2006-12-20 19:05 ` [RFC] " Jimi Xenidis
2006-12-21 10:48 ` Keir Fraser
2006-12-21 17:32 ` Jimi Xenidis
2006-12-21 19:51 ` Keir Fraser
2007-01-16 23:26 ` Jimi Xenidis
2007-01-17 12:20 ` Keir Fraser
2007-01-17 12:50 ` Jimi Xenidis
2007-01-17 13:55 ` Keir Fraser
2007-01-21 16:10 ` Jimi Xenidis
2007-01-21 16:20 ` Keir Fraser
2007-01-21 21:43 ` Jimi Xenidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1AC86AF.6454%keir@xensource.com \
--to=keir@xensource.com \
--cc=jimix@watson.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.