Re: [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal

[Keir Fraser <keir@xensource.com>]

It's been checked in since November.

 -- Keir

On 20/12/06 11:15, "Kasai Takanori" <kasai.takanori@jp.fujitsu.com> wrote:

> Hi Keir and Daniel,
> 
> I also found the same problem and tested this patch.
> I confirmed it was solved by this patch.
> I hope for this patch to be applied.
> 
> Thanks
> 
> --
> Takanori Kasai
> 
> 
> ----- Original Message -----
> From: "Keir Fraser" <keir@xensource.com>
> To: "Daniel P. Berrange" <berrange@redhat.com>; "Keir Fraser"
> <keir@xensource.com>
> Cc: <xen-devel@lists.xensource.com>
> Sent: Thursday, November 30, 2006 1:09 AM
> Subject: Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered inQEMU
> monitor terminal
> 
> 
>> 
>> 
>> 
>> On 29/11/06 15:48, "Daniel P. Berrange" <berrange@redhat.com> wrote:
>> 
>>>> Doesn't this eat the shift/caps key events even when not in qemu monitor
>>>> mode? What if the guest has shortcut key combos involving those keys, for
>>>> example?
>>> 
>>> Re-checking the patch I believe its already doing the correct thing.
>>> 
>>> The do_key_event method is broken into 2 halfs. In the first half, the
>>> keysyms are sent to either the guest OS, or the monitor. In the second
>>> half the shift/caps/ctrl/alt state is being tracked. So the code I added
>>> for tracking shift/caps does not interfere with the earlier code which
>>> actually sends the key press to the guest OS.
>> 
>> Okay, I'll read the code more carefully. :-)
>> 
>> -- keir
>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel