From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Add -Wcast-qual flag Date: Thu, 21 Dec 2006 10:41:53 +0000 Message-ID: References: <200612211105.21248.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200612211105.21248.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 21/12/06 10:05, "Christoph Egger" wrote: > The xen-cast.diff adds the -Wcast-qual flag. We don't enable this flag precisely because we end up needing to scatter const all over the place like confetti. I'm not convinced that use of const improves code quality. I fear we'd end up with 'const foo * const bar' all over the place -- ugly and confusing to most programmers (who frequently mess up const placement, in my experience). -- Keir