From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH][libxc] xc_translate_foreign_address with additional parameter Date: Fri, 05 Jan 2007 14:36:10 +0000 Message-ID: References: <459E5E60.1060002@jikos.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <459E5E60.1060002@jikos.cz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tomas Kouba , xen-devel List-Id: xen-devel@lists.xenproject.org On 5/1/07 14:19, "Tomas Kouba" wrote: > I think it would be handy(*) to have additional function > xc_translate_foreign_address_cr3 that does the same as > xc_translate_foreign_address but with explicit cr3 register. > The actual xc_translate_foreign_address takes its cr3 from > vcpu context. Even better would be to accept cr3, cr4 and efer msr. That's sufficient to work out the execution mode (non-pae, pae, 64-bit). Or the caller could work out the mode and pass it in as an enumeration value (perhaps with a fallback default of 'whatever is most likely'). -- Keir