From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomonari Horikoshi Subject: Re: [PATCH] ioemu : add flush in ide_unplug_harddisks() Date: Tue, 24 Feb 2009 08:46:33 +0900 Message-ID: References: <81C9930B79FFCBt.horikoshi@jp.fujitsu.com> <499E9693.3060708@eu.citrix.com> <18850.53676.560908.266537@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <18850.53676.560908.266537@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , Stefano Stabellini Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Hi. Thank you for the comment. I have understood that it is a best approach to use the IDE flush cache command. I'm sorry I had overlooked the thread. Best regards, Tomonari Horikoshi Ian Jackson san wrote:---------------------- Sent: Mon, 23 Feb 2009 16:41:16 +0000 Subject: Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks() > Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks() > "): > > Tomonari Horikoshi wrote: > > > I think the "flush" is necessary. > > > When "ioemu ide device" changes into "vbd" by "ide_unplug_harddisks()". > > > > I don't think that calling bdrv_aio_flush is a good idea since it is > > asyncronous and right after the call we are going to close the device > > without waiting for completion. > > Yes, bdrv_aio_flush is wrong I think. > > This seems related to the discussion we had in January. As I wrote > in > http://lists.xensource.com/archives/html/xen-devel/2009-01/msg00165.html > it seems to me that the guest should know about be able to flush > for itself ? After all we implement the IDE flush cache command. > > Ian. >