From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] Cleanup asm-x86/guest_access.h
Date: Fri, 12 Jan 2007 13:37:14 +0000
Message-ID: <C1CD3F8A.789C%keir@xensource.com>
References: <907625E08839C4409CE5768403633E0B018E1872@sefsexmb1.amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <907625E08839C4409CE5768403633E0B018E1872@sefsexmb1.amd.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Petersson, Mats" <Mats.Petersson@amd.com>, "Egger, Christoph" <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org




On 12/1/07 12:01, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:

>> copy_{to,from}_user() and copy_{to,from}_user_hvm() expect a non-const
>> argument as the first argument. So I remove the consts from
>> the initializer.
>> I replace typeof with __typeof__, which is always available
>> in gcc - it is 
>> not, when the -ansi option is used.
> 
> And is it expected that Xen will EVER be compiled with -ansi? I think
> there's enough gcc-isms in other places that this will never happen -
> not that it really makes any difference, I'm just curious if anyone
> "cares"... 

Yes, I'm going to take the const cleanups but bin the __typeof__ changes.

 -- Keir