From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: RFC: vaddr_t and vsize_t
Date: Wed, 17 Jan 2007 16:51:58 +0000
Message-ID: <C1D404AE.7C3D%keir@xensource.com>
References: <200701171721.27064.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200701171721.27064.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 17/1/07 16:21, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> This stuff is about removing a place where programmers can make mistakes.
> vaddr_t also avoids void * arithmetics. It should be possible then to use
> -Wpointer-arith.

A bunch of our void* arithmetic comes from files we keep in sync with Linux.
So we'd really need Linux to clean this up before we use -Wpointer-arith, or
we have to do extra porting effort to keep files in sync.

I suppose I don't mind vaddr_t being defined and people using it if they
want to. At least it is probably clearer that translation to/from char* or
long to do pointer arithmetic. However, I'm less sure about a wholesale
conversion of Xen away from use of 'unsigned long'.

 -- Keir