From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Cleanup/fix virt_to_maddr Date: Wed, 24 Jan 2007 11:06:00 +0000 Message-ID: References: <200701241201.32215.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200701241201.32215.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 24/1/07 11:01, "Christoph Egger" wrote: >> They're only used on Xen heap virtual addresses whose physical addresses >> are always below 64MB. So there should be no issues in returning a ulong. > > Oh, I see. So it's absolutely not used for domains (which I assumed)? No, all it does is a simple arithmetic transformation (subtracting PAGE_OFFSET) which is only valid for non-guest pages on x86_32. It can be used for any page on x86_64, but there we have paddr_t==ulong. -- Keir