From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: netfront pv driver building Date: Wed, 24 Jan 2007 14:32:17 +0000 Message-ID: References: <45B779FA.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45B779FA.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Ian Campbell Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 24/1/07 14:23, "Jan Beulich" wrote: > Yes, I think this is dangerous, and I would rather want to see it reverted, > or as a minimum, as you say, converted to ~PAGE_NX (although I dislike > the lost bit of security here). > Especially because, as I said, at present the symbol is needed only for > dead code (so you don't really test whether the change would actually > work the way you want it to), and if at some point it makes it into active > code, we may end up with ugly issues. Setting it to zero would make it very obvious if any usage became live, then we could think harder about this at that time. -- Keir