From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH][RFC] correction trouble of short message
	in UDP
Date: Thu, 25 Jan 2007 14:03:19 +0000
Message-ID: <C1DE6927.8345%keir@xensource.com>
References: <E1HA4q4-0003aC-00@gondolin.me.apana.org.au>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <E1HA4q4-0003aC-00@gondolin.me.apana.org.au>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Herbert Xu <herbert@gondor.apana.org.au>, Keir Fraser <keir@xensource.com>
Cc: t.horikoshi@jp.fujitsu.com, xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 25/1/07 13:40, "Herbert Xu" <herbert@gondor.apana.org.au> wrote:

> How about making the total number of grant table entries equal the
> number of TX slots? That way we won't have to check anything at all.
> 
> It also doesn't make sense to have more TX slots than grant table entries.

Yes, this is a good idea!

So we should replace current netfront_tx_slot_available implementation with:
 (tx->req_prod_pvt - tx->rsp_cons) < (TX_MAX_TARGET - MAX_SKB_FRAGS - 2)

??

 -- Keir