From: Keir Fraser <keir@xensource.com>
To: Keir Fraser <keir@xensource.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: t.horikoshi@jp.fujitsu.com, xen-devel@lists.xensource.com,
xen-ia64-devel@lists.xensource.com
Subject: Re: [PATCH][RFC] correction trouble of short message in UDP
Date: Thu, 25 Jan 2007 14:06:18 +0000 [thread overview]
Message-ID: <C1DE69DA.834A%keir@xensource.com> (raw)
In-Reply-To: <C1DE6927.8345%keir@xensource.com>
On 25/1/07 14:03, "Keir Fraser" <keir@xensource.com> wrote:
>> How about making the total number of grant table entries equal the
>> number of TX slots? That way we won't have to check anything at all.
>>
>> It also doesn't make sense to have more TX slots than grant table entries.
>
> Yes, this is a good idea!
>
> So we should replace current netfront_tx_slot_available implementation with:
> (tx->req_prod_pvt - tx->rsp_cons) < (TX_MAX_TARGET - MAX_SKB_FRAGS - 2)
>
> ??
Sorry, what I'm suggesting actually isn't the same as your proposal. :-)
I think mine would work though, and 256 grants should be plenty as a
maximum.
-- Keir
next prev parent reply other threads:[~2007-01-25 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 11:04 [PATCH][RFC] correction trouble of short message in UDP Tomonari Horikoshi
2007-01-25 12:26 ` Keir Fraser
2007-01-25 13:40 ` Herbert Xu
2007-01-25 14:03 ` Keir Fraser
2007-01-25 14:06 ` Keir Fraser [this message]
2007-01-25 14:17 ` Herbert Xu
2007-01-25 14:21 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1DE69DA.834A%keir@xensource.com \
--to=keir@xensource.com \
--cc=herbert@gondor.apana.org.au \
--cc=t.horikoshi@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
--cc=xen-ia64-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.