All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] Use string bounded functions
Date: Mon, 29 Jan 2007 10:52:42 +0000	[thread overview]
Message-ID: <C1E3827A.85C0%keir@xensource.com> (raw)
In-Reply-To: <200701291110.29420.Christoph.Egger@amd.com>

On 29/1/07 10:10, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> The attached patch replaces sprintf with snprintf and strncpy with strlcpy.
> 
> There are various cases where no NULL-terminated strings are guaranteed
> and eventual possible overflows. This patch fixes them.
> 
> BTW: Since Xen kernel has its own string functions, can't we just remove
> sprintf() and strncpy()? IMO, Xen should not inherit the historical C relicts.

This makes plenty of sense. Strncpy() in particular is dangerous and
strlcpy() is always preferable. So I'd be happy to see strncat/strncpy die.

There are a few uses remaining (particularly in arch/ia64) that you'll have
to fix first.

And please add 'signed-off-by' attribution when you post patches!

 -- Keir

  reply	other threads:[~2007-01-29 10:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29 10:10 [PATCH] Use string bounded functions Christoph Egger
2007-01-29 10:52 ` Keir Fraser [this message]
2007-01-29 11:10   ` Christoph Egger
2007-01-29 13:41     ` Jimi Xenidis
2007-01-29 13:49       ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C1E3827A.85C0%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=Christoph.Egger@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.